480088 - Use a single cached surface for painting with image surfaces

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: use a cached chunk of memory for painting

Since we're using an image surface for painting, we should just allocate a large chunk of memory once, and then keep reusing that.  Allocating a screen-size buffer is probably fine for most devices with CE, since the browser is likely to be fullscreen anyway -- we'd end up having to allocate a surface this size during full-page repaints anyway, and we avoid having to hunt in memory for a large enough chunk later on.

Note that we allocate a large chunk of memory and create new surfaces use this buffer for actual painting -- there's no reason to pay the cache & bandwidth cost of always dealing with the large surface, or even with dealing with a large stride, if we just need a smaller chunk of it.

Comment 1

[Stuart Parmenter]

Comment on attachment 364045 [details] [diff] [review]
use a cached chunk of memory for painting

This is probably ok.  I do worry about it having a negative impact on our perceived memory usage, but lets give it a try.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

checked in.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 364045 [details] [diff] [review]
use a cached chunk of memory for painting

a191=beltzner

Comment 4

[Doug Turner (:dougt)]

vlad, do you want to land this on 1.9.1?

Comment 5

[Karl Tomlinson (:karlt)]

Nudge (in case this has been forgotten).

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 364045 [details] [diff] [review]
use a cached chunk of memory for painting

Revoking approval. We're cutting back on potential churn here. We can try again for 3.5.1