480136 - remove stale Thumb code from nanojit

Status: VERIFIED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Description

[Edwin Smith]

nobody has plans for it, its pure bitrot.  time to go.

Comment 1

[Edwin Smith]

Attachment: fixes to make winmo build again in vs2008

Comment 2

[Edwin Smith]

Attachment: remove nanojit/NativeThumb.*

Comment 3

[Brent Baker]

Comment on attachment 364138 [details] [diff] [review]
fixes to make winmo build again in vs2008

Looks like the patch for platform/win32/avmplus2008.vcproj is a little out of date with the repo. Applying the patch to the file does "succeed" with a couple of offsets for hunks 13-18, which appears to be causing the project to actually become invalid (Visual studio will no longer open the solution).

Comment 4

[Edwin Smith]

you probably need to run dos2unix on the patch before trying to apply it.  when i do that, it applies cleanly.

Comment 5

[Edwin Smith]

Attachment: vs2008 project file patches to make arm buildable again

if you get errors applying this patch:

1. cd tamarin-redux
2. make sure your repo is sync'ed to the change id in line 1 of vcproj.patch
3. dos2unix vcproj.patch
4. patch -p1 -l <vcproj.patch

Comment 6

[Rick Reitmaier]

Comment on attachment 365478 [details] [diff] [review]
vs2008 project file patches to make arm buildable again

I applied the patches one after the other, after reverting the nanojit2008.vcproj changes from the former.

Debug looked fine, but all the other solution configurations looked wrong.  For example Release had eval enabled. 

Marking '-' for now assuming i applied the patches correctly.

Comment 7

[Rick Reitmaier]

Comment on attachment 365478 [details] [diff] [review]
vs2008 project file patches to make arm buildable again

Reverting my - mark and changing it to +.  Apparently my issues stemmed from patch pain.

Comment 8

[Edwin Smith]

Comment on attachment 365478 [details] [diff] [review]
vs2008 project file patches to make arm buildable again

pushed to redux
http://hg.mozilla.org/tamarin-redux/rev/160ed5f38e07

Comment 9

[Edwin Smith]

thumb removal pushed to redux
http://hg.mozilla.org/tamarin-redux/rev/97b6fd60ac5d

Comment 10

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.