Use sizeof on the correct type of ckc_x509 in lib/ckfw

RESOLVED FIXED in 3.12.3

Status

NSS
Libraries
--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 364116 [details] [diff] [review]
Proposed patch

In bug 402712 comment 13, Rob Crittenden fixed a bug in
the new lib/ckfw/pem module where we were passing the
wrong argument CKC_X_509 to the sizeof operator for ckc_x509.

The same code was copied to lib/ckfw/capi and lib/ckfw/nssmkey.
The proposed patch fixes them.
Attachment #364116 - Flags: review?(rrelyea)

Comment 1

9 years ago
Comment on attachment 364116 [details] [diff] [review]
Proposed patch

r+ rrelyea

Thanks for noticing this and getting it fixed Wan-Teh!

bob
Attachment #364116 - Flags: review?(rrelyea) → review+
(Assignee)

Comment 2

9 years ago
I checked in the patch on the NSS trunk (NSS 3.12.3).

Checking in capi/cobject.c;
/cvsroot/mozilla/security/nss/lib/ckfw/capi/cobject.c,v  <--  cobject.c
new revision: 1.5; previous revision: 1.4
done
Checking in nssmkey/mobject.c;
/cvsroot/mozilla/security/nss/lib/ckfw/nssmkey/mobject.c,v  <--  mobject.c
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.