Last Comment Bug 480142 - Use sizeof on the correct type of ckc_x509 in lib/ckfw
: Use sizeof on the correct type of ckc_x509 in lib/ckfw
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.12
: All All
-- minor (vote)
: 3.12.3
Assigned To: Wan-Teh Chang
Depends on:
  Show dependency treegraph
Reported: 2009-02-25 09:55 PST by Wan-Teh Chang
Modified: 2009-02-25 11:15 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Proposed patch (3.19 KB, patch)
2009-02-25 09:55 PST, Wan-Teh Chang
rrelyea: review+
Details | Diff | Splinter Review

Description User image Wan-Teh Chang 2009-02-25 09:55:23 PST
Created attachment 364116 [details] [diff] [review]
Proposed patch

In bug 402712 comment 13, Rob Crittenden fixed a bug in
the new lib/ckfw/pem module where we were passing the
wrong argument CKC_X_509 to the sizeof operator for ckc_x509.

The same code was copied to lib/ckfw/capi and lib/ckfw/nssmkey.
The proposed patch fixes them.
Comment 1 User image Robert Relyea 2009-02-25 10:05:37 PST
Comment on attachment 364116 [details] [diff] [review]
Proposed patch

r+ rrelyea

Thanks for noticing this and getting it fixed Wan-Teh!

Comment 2 User image Wan-Teh Chang 2009-02-25 11:15:55 PST
I checked in the patch on the NSS trunk (NSS 3.12.3).

Checking in capi/cobject.c;
/cvsroot/mozilla/security/nss/lib/ckfw/capi/cobject.c,v  <--  cobject.c
new revision: 1.5; previous revision: 1.4
Checking in nssmkey/mobject.c;
/cvsroot/mozilla/security/nss/lib/ckfw/nssmkey/mobject.c,v  <--  mobject.c
new revision: 1.4; previous revision: 1.3

Note You need to log in before you can comment on or make changes to this bug.