480145 - BuildStepStatus.setColor shouldn't be called from custom steps

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Axel Hecht [:Pike]]

For 0.7.10, setColor might go away, or not. Anywho, we should stop calling in to it from our custom build steps, I don't see a need to do so even in 0.7.9.

Comment 1

[[e-mail] (:bhearsum)]

I'll take care of this.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: remove setColor calls

Dead simple. Just removes all of setColor calls. 

We can't remove this until we upgrade, however, because we don't have the upstream code that deals with setting the color based on the step status. All of the finalizing setColor calls are right alongside finished(), so we shouldn't see any difference in behaviour when it does land.

Comment 3

[Axel Hecht [:Pike]]

Marking the dependency on 0.7.10 aka bug 481886.

I wonder if we should assume we have a working patch, if we don't know which steps we'll see by the time we actually get to .10.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 370648 [details] [diff] [review]
remove setColor calls

Axel, ping?

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 370648 [details] [diff] [review]
remove setColor calls

oops. r=me

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 370648 [details] [diff] [review]
remove setColor calls

changeset:   267:eeb8c637e019

Comment 7

[[e-mail] (:bhearsum)]

I just reconfig'ed production-master and try-master for this.