480157 - Quickfind doesn't work on shacknews.com when certain ads are served

Status: NEW

(Toolkit :: Find Toolbar, defect, P2)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090225 Shiretoko/3.1b3pre ID:20090225031913

1. New profile, start Firefox
2. Navigate to www.shacknews.com and allow the page to finish loading
3. Press / to bring up the quickfind search bar at the bottom of the browser window
4. Type in a random assortment of characters

Expected:
- You are notified that the text couldn't be found

Actual:
- You can type what you want and it is never found, even a term that does exist on the page

The full search (CTRL+F) appears to work correctly. Range coming up.

Comment 1

[Steve England [:stevee]]

Correction: If you search for a word that does exist, then the Quick Find bar will show it only after you hit F3 (next). However, if you search for nonsense the Quick Find bar never indicates that it hasn't found anything.

This bug does not effect all websites.

Works: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090126 Shiretoko/3.1b3pre
Built from http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c19399e9c815

Busts:  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre
Built from http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9c6a7e570995

http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=c19399e9c815&tochange=9c6a7e570995

I wouldn't like to guess at what caused this.

Comment 2

[Nochum Sossonko [:Natch]]

I'd say bug 475471, but That's Just Me.

Comment 3

[Steve England [:stevee]]

Roc had a lot of bugs land in this range so let's CC him and see what he says :-)

Comment 4

[Martijn Wargers (dead)]

Or perhaps caused by one of the check-ins from Blake?

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is this broken on trunk? If it is, and we get a trunk regression range, then we can look for checkins in the intersection and get a much narrower set of suspects.

Comment 6

[Mike Connor [:mconnor]]

A trunk regression range would be fantastic, for the reasons roc notes.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Adding Enn and Ryan since they have checkins in the regression range.

Comment 8

[Steve England [:stevee]]

Sigh. OK. So it seems like this bug is actually dependent on what ads are served at the time you view the page, so the range in comment 0 is wrong. Further, this bug is also reproducible in Firefox 3.0.6 and also 2.0.0.13pre.

Better steps to reproduce:
1. Visit http://www.shacknews.com/extras/submit_news.x
2. File > Save Page As... and save the page to your desktop
3. Drag the just-saved .html file into the browser window. The page will load with a lot of adverts all the way down the page (rather than just one at the top)
4. Press / and do a search for random gibberish and you are not notified that nothing has been found

So this appears to be a long-standing bug and the blocking flag can probably be removed. I'll try for a regression range but one may not exist.