480223 - Admin page is borked due to Minify patch

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Thanks to Eric for finding this bug.

The Admin panel is beyond borked:

https://support-stage.mozilla.org/tiki-admin.php

Screenshot to follow; regression from the Minify bug (bug 444265).

Comment 1

[Chris Ilias [:cilias]]

Just my opinion, but so long as those links work, this shouldn't block 0.9. I can live with it until 1.0. :-)

Comment 2

[Paul Craciunoiu [:paulc]]

r22643 / r22644
Trivial fix. admin.css was not added to the minify library. However, I will have to look into this to make sure all css files are included there, as some other bugs may pop up. I'll look into the JS page edit bug next - it might be the same kind of issue.

Comment 3

[Paul Craciunoiu [:paulc]]

Oh yeah, memcached cache needs to be cleared for us to test this. But it works locally for me after I did that.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.org/tiki-admin.php?locale=en-US, after I reloaded cache (memcahed refreshed, it seems).

Comment 5

[Louis-Philippe Huberdeau]

Different implementation made for javascript minification. Probably not final.

From headerlib, if minification is enabled, the list of required files is used to generate a hash. If the file does not yet exist, a static file is generated. Apache will serve the files, which avoids using PHP for it.

Memcache not used at all.

There are possible issues if different files use different file sets.