480279 - Allow mochitests to launch under a debugger or valgrind

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1 [Checkin: See comment 4 & 5]

Simple changes to launch the mochitest harness under a debugger. Works great for valgrind, a little less great for gdb, but what do you guys think? This at least means I don't have to hack the harness when I want to run valgrind.

Comment 2

[(not currently active) Ted Mielczarek]

I filed bug 477269 not long ago, but you have a patch.

Comment 3

[Jeff Walden [:Waldo]]

Looks good to me, but I'd probably have to play with it for awhile to be completely confident that the mode of interaction is optimal.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Pushed changeset 356458e646d0 to mozilla-central.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 364281 [details] [diff] [review]
Patch, v1
[Checkin: See comment 4 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3ed22a6e3f37

After fixing context for:
{
patching file build/automation.py.in
Hunk #1 FAILED at 401
Hunk #3 FAILED at 446
2 out of 3 hunks FAILED
patching file testing/mochitest/runtests.py.in
Hunk #5 FAILED at 466
1 out of 5 hunks FAILED
}

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I guess I don't mind that this was checked in on branch but I don't see anyone giving approval for it landing there...

Comment 7

[Jeff Walden [:Waldo]]

It's a testing-only change, and those have never required approval.  Maybe this is a lenient interpretation of the policy, but "beg forgiveness" > "ask permission" in my book as long as you're sure the change won't break anything.  ;-)

Comment 9

[(not currently active) Ted Mielczarek]

Yes, I have been broadly interpreting the testing approval grant to include test harness changes. I have yet to hear a complaint from other drivers, so I conclude that nobody minds.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Using this to run gdb doesn't work for me on Mac.  See bug 485531.