480501 - Crash reports open with modules instead of frame tab

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the latest upgrade of Soccorro crash reports open with the module list. That's not really helpful because everybody has to switch back to the stack frames tab.

Opening referenced crash reports from about:crashes or Bugzilla should still display the stack frames.

Comment 1

[Austin King [:ozten]]

I'm happy to change this, but we should get some consensus on what's most usable. This was a request in IRC by several people. I will try to find my notes / bug#.

Comment 2

[Austin King [:ozten]]

I've commited this fix in r914
Index: index.php
===================================================================
--- index.php	(revision 910)
+++ index.php	(working copy)
@@ -11,8 +11,7 @@
 
   <script type="text/javascript">//<![CDATA[
       $(document).ready(function(){
-	  $('#report-index > ul').tabs({selected: 2});
-	//$('#report-index > ul').tabs('select', 2);
+        $('#report-index > ul').tabs({selected: 1});
         $('#showallthreads').removeClass('hidden').click(function(){
         $('#allthreads').toggle(400);
           return false;

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Austin, was you able to find notes about that? I don't wanna work against other people who had reasonable arguments to select the modules tab instead of the frames tab.

Comment 4

[Austin King [:ozten]]

Nope. I must have invented this requirement.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, so when this goes live we can mark it as fixed. Thanks.

Comment 6

[Samuel Sidler (old account; do not CC)]

Yes, we should fix this.

Comment 7

[Austin King [:ozten]]

This regression is fixed in prod.
Sorry about my dementia.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Austin. Verified.