480524 - Create infrastructure for automated fennec maemo l10n builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Axel Hecht [:Pike]]

We need an automated infrastructure for fennec l10n builds. These are going to repacks of existing builds, like we do for other apps.

Comment 1

[Axel Hecht [:Pike]]

http://hg.mozilla.org/users/axel_mozilla.com/buildbotcustom/rev/a4fefecd4689 is the buildbotcustom part.

This goes along with http://hg.mozilla.org/users/axel_mozilla.com/tooling/rev/b196540ace5b, which has the modifications for the build factory, and some fixes for the web status to force builds.

Comment 2

[Axel Hecht [:Pike]]

We need a builder and slaves to run that builder on, per platform desired.

For the builder, things like make ident to get the en-US binary stamps should already work, so subclassing NightlyRepackFactory to get the right sources is pretty easy. For reference, the factory I'm currently using on the l10n server is at http://hg.mozilla.org/users/axel_mozilla.com/tooling/file/a31e2fc2dc70/l10nbuilds/l10nbuilds/process/factory.py#l211. As a heads up, that factory will go out of business with the next major update of the master on the l10n server.

For l10nbuilds.ini, I suggest to copy http://hg.mozilla.org/users/axel_mozilla.com/l10n-master/file/4f95b95163a8/l10nbuilds.ini#l21

[fennec10x]
app = mobile
type = single-module-hg
locales = all
mozilla = mobile-browser
l10n = l10n-central
repo = http://hg.mozilla.org/
revisions = en l10n toolkit
l10n.ini = locales/l10n.ini
builders = compare

This version proved to be better than the one that I use on the l10n server, and is going to replace it after fx3b4 in l10n master v2.

The whole scheduling and dispatcher foo is dealt with and works on the l10n server as it is used on the production machines, so just setting the type to single-module-hg should do the trick there. I don't have patches to that code for l10n master v2 either.

As this is much more of a resources and staging/production problem than a l10n infra problem, I'm putting this bug back into the releng pool.

I'm happy to do reviews, of course.

Comment 3

[Aki Sasaki (not active)]

By the look of it, you don't need to run anything in scratchbox for this... is that correct?

Comment 4

[Axel Hecht [:Pike]]

The l10n repacks need to get the right platform/os whatnot settings for the package names. On linux, I've been able to fake that for linux arm with specifying a target. I have had less luck with that for WinCE.

So, in theory, yeah, you don't. In practice, I don't know how to reliably set up a cross compile setup.

Comment 5

[Axel Hecht [:Pike]]

I've not set up scratchbox set up, so at least for linux arm, it seems to work without running things inside scratchbox.

Comment 6

[Aki Sasaki (not active)]

I'm making good progress on this: I'm able to repack all the locales (dying on the not-fully-translated ones, of course) for mozilla-central/mobile-browser, and upload tarballs to staging-stage.

As a quick check, I tried repacking mozilla-1.9.1/mobile-browser, and I got this during a 'make wget-en-US':

  Makefile:63: ../../toolkit/locales/l10n.mk: No such file or directory
  make: *** No rule to make target `../../toolkit/locales/l10n.mk'.  Stop.

Is this a known issue?

Comment 7

[Axel Hecht [:Pike]]

Nice, and yes, I filed bug 489313 to get l10n.mk on to 1.9.1.

Comment 8

[Aki Sasaki (not active)]

Attachment: buildbot-configs patch for maemo_trunk_l10n_nightly_builder

buildbot-configs portion of the patch.  I'm also adding clobberURL and clobberTime to all mobile factories; I can take that out for cleanliness if requested.

I moved the baseWorkDir to /scratchbox/users/cltbld/home/cltbld/l10n so we can |make deb| at some point.

Setting reviewer to Coop but welcome any reviews/comments.

Patch 1 of 2.

Comment 9

[Aki Sasaki (not active)]

Attachment: buildbotcustom patch for MaemoNightlyRepackFactory

I had to refactor BaseRepackFactory a bit and added WithProperties capabilities to packageGlob.  Tested against mozilla-central+mobile-browser.  Also tested Linux mozilla-central l10n and Linux mozilla-1.9.1 l10n to make sure I didn't bork things.  Patch 2/2.

Comment 10

[Chris Cooper [:coop] (he/him)]

Comment on attachment 373897 [details] [diff] [review]
buildbot-configs patch for maemo_trunk_l10n_nightly_builder

> status.append(TinderboxMailNotifier(
>     fromaddr="[e-mail]",
>     tree='MozillaTest',
>     extraRecipients=["[e-mail]"],
>     relayhost="mail.build.mozilla.org",
>     builders=["mobile-linux-arm-dep", "mobile-linux-arm-nightly",
>-              "mobile-wince-arm-dep", "mobile-wince-arm-nightly"],
>+              "mobile-wince-arm-dep", "mobile-wince-arm-nightly",
>+              'Maemo mozilla-central l10n'],
>     logCompression="bzip2"
> ))

Are we not adding the notifier for 1.9.1 yet? Does it matter?

>+status.append(TinderboxMailNotifier(
>+    fromaddr="[e-mail]",
>+    tree='Mozilla-l10n',
>+    extraRecipients=["[e-mail]"],
>+    relayhost="mail.build.mozilla.org",
>+    builders=['Maemo mozilla-central l10n'],
>     logCompression="bzip2"
> ))

Same question as above.

Looks good otherwise.

Comment 11

[Chris Cooper [:coop] (he/him)]

Comment on attachment 373898 [details] [diff] [review]
buildbotcustom patch for MaemoNightlyRepackFactory

>-            releaseToDated=False,
>+            releaseToDated=self.nightly,

Do we need to explicitly keep dated copies as well?

>+    # Upload targets aren't defined in mobile/locales/Makefile,
>+    # so use MozillaStageUpload for now.

Is there a bug on file for that?

The patch didn't apply cleanly, but after some cut-n-paste I did get this running and working on staging, modulo the locales that are currently busted (de, he, it, ja, ja-JP-mac, ro, sl, zh-TW). 

I'll post the patch as tested shortly, because that one will apply cleanly against the current tip.

Comment 12

[Chris Cooper [:coop] (he/him)]

Attachment: buildbotcustom patch for MaemoNightlyRepackFactory, v2

This is the updated version of attachment 373898 [details] [diff] [review] that applies cleanly against the current tip. This has already been run successfully through staging.

Comment 13

[Aki Sasaki (not active)]

Comment on attachment 373898 [details] [diff] [review]
buildbotcustom patch for MaemoNightlyRepackFactory

> Are we not adding the notifier for 1.9.1 yet? Does it matter?

It's not in the scheduler and we have no builds for 1.9.1 yet... bug 489472.  I figure I'll enable both when it's ready.

Checked in; rev  259:98200ef46531

Comment 14

[Aki Sasaki (not active)]

Comment on attachment 373897 [details] [diff] [review]
buildbot-configs patch for maemo_trunk_l10n_nightly_builder

Oops, I guess I've switched my replies to be on the wrong patches.

The dated directories bit was missing from a long time ago; bhearsum wanted it for the nightly mobile builds but the patch got checked in without it.  Kind of sneaking it in here.

I was able to hg pull -u and check in without conflicts after double checking my changes.

checked in; rev 1103:3729fa7eda74

Comment 15

[Aki Sasaki (not active)]

Changing the summary as I don't think we have the means to do WinCE repacks yet.

Comment 16

[Aki Sasaki (not active)]

I was waiting on 1.9.1 builds, at which point I'd enable 1.9.1 l10n and resolve fixed.  Since 1.9.1 builds aren't here yet and I can enable them with a simple bool change, resolving.