Closed
Bug 480558
Opened 17 years ago
Closed 17 years ago
Talos should be more lenient about defunct processes
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.64 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
In Talos ffprocess_linux.py there is code to check whether there are any firefox processes still running: this code uses `ps ax`. Sometimes, though, a crashed process can be fully-dead but Talos hasn't waited on it yet, so it's defunct and shows up in the ps output like this:
4853 pts/0 Z+ 0:00 [firefox] <defunct>
GetPidsByName should ignore defunct processes.
| Assignee | ||
Comment 1•17 years ago
|
||
Attachment #364530 -
Flags: review?(anodelman)
Updated•17 years ago
|
Attachment #364530 -
Flags: review?(anodelman) → review+
Comment 2•17 years ago
|
||
Comment on attachment 364530 [details] [diff] [review]
Skip defunct processes, rev. 1
Should a similar check be made for mac/win?
| Assignee | ||
Comment 3•17 years ago
|
||
Mac yes, Windows no (Windows uses an entirely different mechanism and doesn't have any concept of defunct processes).
Is this something I can just check in, or does it need to have scheduled downtime?
Attachment #364530 -
Attachment is obsolete: true
Attachment #364566 -
Flags: review+
Comment 4•17 years ago
|
||
We only require downtime for checkins that are risky or alter the talos numbers. This can land anytime and I don't believe that it should affect active machines or their numbers.
| Assignee | ||
Comment 5•17 years ago
|
||
bsmedberg $ cvs commit ffprocess_linux.py ffprocess_mac.py
Checking in ffprocess_linux.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess_linux.py,v <-- ffprocess_linux.py
new revision: 1.11; previous revision: 1.10
done
Checking in ffprocess_mac.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess_mac.py,v <-- ffprocess_mac.py
new revision: 1.12; previous revision: 1.11
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•