480638 - Creating Porting APIs for logging messages and debug info

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Rishit Shah]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.6) Gecko/2009011912 Firefox/3.0.6
Build Identifier: 

Tamarin codebase uses printf, fprintf functions in the core code to output diagnostic and debug information.

We want provide APIs that can be implemented by the platform in their defined way to print or gather this information.

Reproducible: Always

Comment 1

[Rishit Shah]

Attachment: Patch [v1] - logging APIs

Summary -

3 new APIs - VMPI_Log, VMPI_DebugLog and VMPI_DebugBreak


Removed GCDebug[Win/Mac/Unix] and replaced it with (core) GCDebug.cpp
Added GCLog() to replace printf/fprintf usage for MMgc


Removed AvmDebug[Win/Mac/Unix] and replaced it with (core) AvmDebug.cpp
Added AvmLog() to replace printf/fprintf usage for avmplus

Platform specific implementations of Log/DebugLog and DebugBreak added new files [Win/Posix]PortUtils under shell directory.

Comment 2

[Lars T Hansen]

Comment on attachment 365071 [details] [diff] [review]
Patch [v1] - logging APIs

I got a lot of merge failures here because of Tommy's mega-checkin, but the API looks OK to me.  Not reviewed in depth.

Comment 3

[Edwin Smith]

Comment on attachment 365071 [details] [diff] [review]
Patch [v1] - logging APIs

If GCLog and AVMLog are two api's for the exact same functionality, it'd be nice to have just one.  other than that nit, looks ok.

Comment 4

[Rishit Shah]

Right now they are similar but they would be different once AvmLog would in turn use PrintWriter::formatV like function to format the string instead of using vsprintf.

Comment 5

[Rishit Shah]

Attachment: Final patch [v2] - incorporating feedback from patch [v1] review

Comment 6

[Lars T Hansen]

I find this to be unreviewable, there is a large number of merge problems.  Which patches are you assuming to be applied before this one is applied?

Comment 7

[Lars T Hansen]

Comment on attachment 365473 [details] [diff] [review]
Final patch [v2] - incorporating feedback from patch [v1] review

tentatively approved.  awaiting new patches, i will take care of landing it.

Comment 8

[Rishit Shah]

Fixed changesets: 6183b3f1b6d8

Comment 9

[Rishit Shah]

In correct changeset above.

The correct one is - ba7b9909c018