Closed Bug 480768 Opened 15 years ago Closed 15 years ago

Menus don't turn gray when a dialog is opened, and turn gray when it's closed (even though the main window is focused)

Categories

(Core :: DOM: Events, defect)

1.9.1 Branch
x86
Windows Vista
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: Natch, Unassigned)

References

Details

(Keywords: regression, verified1.9.1, Whiteboard: [fixed by bug 480767])

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090228 Minefield/3.2a1pre

Summary says it all, 3.1 branch doesn't suffer from this yet. I'll look for a regression range.

STR:

1. open the clear recent history dialog.
2. observe main window menu text is still black.
3. close the dialog.
4. observe the main window menu text has now turned gray.
Flags: blocking-firefox3.2?
works: 2009-02-26
broken: 2009-02-27
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a979ac23e17e&tochange=cc8d4e656113

No idea which one specifically did this...
Keywords: regression
Alas I was wrong, this does happen on 3.1 latest... I'll try to get a range for that as well.
Flags: blocking-firefox3.2? → blocking-firefox3.1?
in 3.1:

works: 2009-02-27
broken: 2009-02-28
pushlog: http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=9865a6c60c5b&tochange=53bc33d54b14

I suspect one of Olli's checkins, though can't be sure...
hg bisect:

The first bad revision is:
changeset:   25570:7184f7d69ff0
user:        Olli Pettay <opettay@mozilla.com>
date:        Thu Feb 26 14:00:30 2009 -0800
summary:     Bug 333198 - 'Suppress Input events for web content during synchron
ous XMLHttpRequest loads'. r=bz, sr=jst, a=blocking1.9.1+
Blocks: 333198
Updating summary to reflect what is happening, after this happens you can no longer type in the address bar, etc.
Component: Menus → DOM: Events
Flags: blocking-firefox3.1?
Product: Firefox → Core
QA Contact: menus → events
Summary: Menus don't turn gray when a dialog is opened, and turn gray when it's closed (even though the main window is focused) → Events on parent window are suppressed when modal dialog is opened.
Version: Trunk → 1.9.1 Branch
IMHO this should be a beta 3 blocker as the focus and event delivery is pretty much clobbered.
Flags: blocking1.9.1?
This does only affect textboxes for the current xul window, right? Other elements seem to work. It's a Windows only bug and not reproducible on Linux or OS X.

Beltzner, what do you think?
Well not entirely, it screws up focus in general, hence the str. See also bug 480767.
This bug is marked as Core but I'm not seeing it (or any duped bug behaviours) in Seamonkey. Using Windows XP.


Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090228 SeaMonkey/2.0b1pre - Build ID: 20090228001403
Is this bug also causing the navigation keys to stop working ? 
Navigation keys, arrow keys, pg/up/dwn/home/end all quit working after entering into and exiting Private Browsing. 

No errors in console2.  
Seeing this using Vista HP SP1 trunk builds:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090228 Minefield/3.2a1pre Firefox/3.0.4 ID:20090228133751

Latest hourly with changeset: 
http://hg.mozilla.org/mozilla-central/rev/40a26979f070
This was done on purpose, but apparently there
Summary: Events on parent window are suppressed when modal dialog is opened. → Menus don't turn gray when a dialog is opened, and turn gray when it's closed (even though the main window is focused)
(In reply to comment #13)
> This was done on purpose, but apparently there
Er, I mean "Events on parent window are suppressed when modal dialog is opened. "
was done on purpose. But of course not the menu handling change.
I think limiting suppression to content docshells might work well enough.
I'll try to find some solution ASAP, or backout all the timeout suspension / user event suppression changes.
Smaug, it isn't just a "menu handling" problem, see the duplicate bugs, the events are suppressed *after* the dialog has been closed, that is the problem. If I open a modal dialog, I can't type anything into any text input until I unfocus the window, then refocus it.

There also seems to be a focus problem, the focus isn't taken from the parent window until the dialog is closed.
Bug 480767 isn't a dup of this one.
I can see this problem too when switching and leaving the Private Browsing mode. I've disabled the dialog, so no modal dialog is needed to get into this state.
That tryserver fixes all the regressions for me.
This is seemingly WFM - fixed by 333198 ? 

Using Vista HP SP1

today's nightly:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090304 Minefield/3.2a1pre Firefox/3.0.4 ID:20090304034918
Bug 333198 caused this, then it was backed out and pushed back
with the fix for Bug 480767.
Smaug and others, this is fixed now, right?
This is fixed for me and Smaug mentioned in bug 480767 comment 7 that it would.
Status: NEW → RESOLVED
Closed: 15 years ago
Depends on: 480767
Resolution: --- → FIXED
Whiteboard: [fixed by bug 480767]
Verified fixed on trunk and 1.9.1:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090304 Shiretoko/3.1b3pre ID:20090304033811

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090304 Minefield/3.2a1pre ID:20090304034918
Status: RESOLVED → VERIFIED
Flags: blocking1.9.1?
Keywords: verified1.9.1
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.