Closed
Bug 480826
Opened 16 years ago
Closed 16 years ago
Firefox should honour browser.chrome.favicons setting when opening Edit->Preferences->Applications
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.6b1
People
(Reporter: mail, Unassigned)
References
Details
Attachments
(1 file)
542 bytes,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.0.6) Gecko/2009022823 Firefox/3.0.6
Build Identifier: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.0.6) Gecko/2009022823 Firefox/3.0.6
When opening Edit->Preferences->Applications and selecting an Action a list
of actions pops up. If this list contains URLs for websites, their favicons
are loaded even if browser.chrome.favicons is set to false.
Reproducible: Always
Steps to Reproduce:
1. rm -rf .mozilla
2. Set browser.chrome.favicons to false
3. Open Edit->Preferences->Applications
4. Select the "Web Feed" action and view favicons being loaded
Actual Results:
The favicons are being loaded even if browser.chrome.favicons is set to false.
Expected Results:
The favicons should not be loaded.
Here is the patch I use:
--- browser/components/preferences/applications.js.ORI 2008-10-24 07:37:29.000000000 +0200
+++ browser/components/preferences/applications.js 2009-03-01 11:54:25.000000000 +0100
@@ -1894,7 +1894,7 @@
// they'll only visit URLs derived from that template (i.e. with %s
// in the template replaced by the URL of the content being handled).
- if (/^https?/.test(uri.scheme))
+ if (/^https?/.test(uri.scheme) && this._prefSvc.getBoolPref("browser.chrome.favicons"))
return uri.prePath + "/favicon.ico";
return "";
Reporter | ||
Comment 1•16 years ago
|
||
Reporter | ||
Comment 2•16 years ago
|
||
Should be "patch" and not "oatch" ;-)
Reporter | ||
Updated•16 years ago
|
Version: unspecified → 3.0 Branch
Comment 3•16 years ago
|
||
Isn't this Bug 403650 ?
Reporter | ||
Comment 4•16 years ago
|
||
(In reply to comment #3)
> Isn't this Bug 403650 ?
Don't think so. They talk about expiring, I simply don't want to load
them when the pref setting is off.
Updated•16 years ago
|
Attachment #364788 -
Flags: review?(mconners)
Updated•16 years ago
|
Attachment #364788 -
Flags: review?(mconners) → review?(mconnor)
Comment 5•16 years ago
|
||
I can confirm this bug,
making http requests while setting browser options is not a good idea.
Updated•16 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•16 years ago
|
Severity: normal → minor
OS: FreeBSD → All
Hardware: x86 → All
Comment 6•16 years ago
|
||
Comment on attachment 364788 [details] [diff] [review]
Here is a patch which fixes the problem
This is fine, though I think what would ultimately be better is to figure out how to selectively fetch from the favicon service, but not download otherwise.
Attachment #364788 -
Attachment description: Here is a oatch which fixes the problem → Here is a patch which fixes the problem
Attachment #364788 -
Flags: review?(mconnor) → review+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 7•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6b1
You need to log in
before you can comment on or make changes to this bug.
Description
•