480826 - Firefox should honour browser.chrome.favicons setting when opening Edit->Preferences->Applications

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.0.6) Gecko/2009022823 Firefox/3.0.6
Build Identifier: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.0.6) Gecko/2009022823 Firefox/3.0.6

When opening Edit->Preferences->Applications and selecting an Action a list
of actions pops up. If this list contains URLs for websites, their favicons
are loaded even if browser.chrome.favicons is set to false.

Reproducible: Always

Steps to Reproduce:
1. rm -rf .mozilla
2. Set browser.chrome.favicons to false
3. Open Edit->Preferences->Applications
4. Select the "Web Feed" action and view favicons being loaded
Actual Results:  
The favicons are being loaded even if browser.chrome.favicons is set to false.

Expected Results:  
The favicons should not be loaded.

Here is the patch I use:

--- browser/components/preferences/applications.js.ORI  2008-10-24 07:37:29.000000000 +0200
+++ browser/components/preferences/applications.js      2009-03-01 11:54:25.000000000 +0100
@@ -1894,7 +1894,7 @@
     // they'll only visit URLs derived from that template (i.e. with %s
     // in the template replaced by the URL of the content being handled).
 
-    if (/^https?/.test(uri.scheme))
+    if (/^https?/.test(uri.scheme) && this._prefSvc.getBoolPref("browser.chrome.favicons"))
       return uri.prePath + "/favicon.ico";
 
     return "";

Comment 1

[[e-mail]]

Attachment: Here is a patch which fixes the problem

Comment 2

[[e-mail]]

Should be "patch" and not "oatch" ;-)

Comment 3

[Ria Klaassen (not reading all bugmail)]

Isn't this Bug 403650 ?

Comment 4

[[e-mail]]

(In reply to comment #3)
> Isn't this Bug 403650 ?

Don't think so. They talk about expiring, I simply don't want to load
them when the pref setting is off.

Comment 5

[mojespamkonto]

I can confirm this bug,
making http requests while setting browser options is not a good idea.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 364788 [details] [diff] [review]
Here is a patch which fixes the problem

This is fine, though I think what would ultimately be better is to figure out how to selectively fetch from the favicon service, but not download otherwise.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/52d5e6ab0cfe