480960 - while trying to use litmus, I noticed the radio buttons on the forms do not get marked

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I found that when we click on a radio button (maemo only) it doesn't fill in the bubble and confuses the end user.  It appears that we do submit the value when the form is submitted.

The was found while trying to view litmus on the device.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

After clicking on a radio button, if you pan or scroll did it appear checked?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> After clicking on a radio button, if you pan or scroll did it appear checked?

Not for me

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Update: I applied the patch in bug 487693 and now I see a different behavior:
* If I click directly on the radio button, it is updated correctly.
* If I click on the label associated with the radio button, the radio is not updated.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> (In reply to comment #1)
> > After clicking on a radio button, if you pan or scroll did it appear checked?
> 
> Not for me

Actually, in a build without the patch in bug 487693, the radio is updated after a pan. Clicking on the radio or clicking on the label both update after a pan.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Mark, when you say updated after a pan, do you mean checked or focused? 

On my build it's just focused (I have include a workaround in bug 492831) due of the inner way of the label element to handle the 'for' atttribute. I suppose we can do a patch directly in ContentClickingModule but that seems to be an exception only for the label element.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

I was able to see this work with a build from 6/24

Comment 7

[Ben Combee (:bcombee)]

Joel, this was fixed by the endPanning change for bug 504673 which prevented some screen updates after a click event.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks for cleaning this up bcombee.  Planning on doing another test pass over the next two weeks and will verify all is good.