481119 - forgot password mail not received

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please check if the mail from the "Forgot Password" page is really sent. I registered, logging in didn't work, so I wanted to try this way.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Using the by "username" field didn't work, but the direct email address did.

Comment 2

[David Tenser [:djst]]

If this one's hard to fix, we might just want to remove the option of entering your user name.

Comment 3

[Paul Craciunoiu [:paulc]]

I'm sure it's not that hard to fix. I could look into it, but after other 1.1s :)
Laura will probably be very busy in the next few.

Comment 4

[Paul Craciunoiu [:paulc]]

Attachment: Patch: proposed fix, v1

The mail was sent to $_REQUEST['email'] which obviously wouldn't be available when username is provided. This simple patch makes sure that the email gets assigned in that other case too. Should be easy to review :)

Comment 5

[Paul Craciunoiu [:paulc]]

Comment on attachment 376529 [details] [diff] [review]
Patch: proposed fix, v1

Eric, if you have more time, you could take a quick look.

Comment 6

[Paul Craciunoiu [:paulc]]

Oops, I must've unassigned this by accident.

Comment 7

[Paul Craciunoiu [:paulc]]

r25731 / r25732

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Sadly, reopening; I still can't get this to work on staging (though retrieving password via an entered email address works just fine, so it shouldn't be a staging-config issue?)

Comment 9

[Paul Craciunoiu [:paulc]]

Re-resolving after staging issue has been fixed (bug 493674).

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; just tried this on https://support-stage.mozilla.org/tiki-remind_password.php and it emailed me my username, gave the IP address from which the request was sent, as well as a unique, one-time link to log in.

Comment 11

[Paul Craciunoiu [:paulc]]

Yay, this works on prod now. :)

Comment 12

[Paul Craciunoiu [:paulc]]

Comment on attachment 376529 [details] [diff] [review]
Patch: proposed fix, v1

Just going through my r? list