Closed Bug 481152 Opened 16 years ago Closed 6 years ago

Open Context class for extension

Categories

(Rhino Graveyard :: Core, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INACTIVE

People

(Reporter: mguillemot, Unassigned)

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009020911 Ubuntu/8.04 (hardy) Firefox/3.0.6
Build Identifier: 

A lot of Context's class methods are final without any clear reason. Removing these final declarations and making some other internal utilities protected would facilitate extension, for instance for following use case which is surely common: we (in HtmlUnit) want to inspect the JavaScript code (as string) before execution. We can do this without problem when we call Context's methods by ourself, but not when eval is called from the executed JS script. eval calls Context.compileString(String, Evaluator, ErrorReporter, String, int, Object) and therefore we could easily inject our behaviour here if we had the possibility to overwrite this method.

Reproducible: Always

Closing. Bug management is now done here:
https://github.com/mozilla/rhino

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.