481198 - need to be able to clear msgWindow on a url

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

nsMsgMailNewsUrl::SetMsgWindow doesn't do anything if the passed in msg window is null. For the auto config code, I need the ability to clear the msg window on a url. Patch upcoming.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 365201 [details] [diff] [review]
proposed fix

do_GetWeakReference seems to cope with null values: http://mxr.mozilla.org/comm-central/source/mozilla/xpcom/glue/nsWeakReference.cpp#100

can't we just drop the if?

Comment 2

[David :Bienvenu]

Attachment: fix addressing comment

right you are...

Comment 3

[David :Bienvenu]

fix checked in.

Comment 4

[Tobias Fischer]

This regressed the MailNews Header-View, see Bug 481590. Sorry, but I don't know if this blocks or depends on the regression Bug, please correct this if I have set the wrong dependency.

Comment 5

[Mark Banner (:standard8)]

I knew I was a bit cautious about this. TB and SM both showed the not marking newsgroup message as read issue, only SM showed the not displaying newsgroup headers properly issue.

I've backed it out for now whilst we look at this. The marking read issue seems to be that we set the message window to a value, then later in the protocol setup, it gets stamped over by setting it to null, because it doesn't have the message window at that stage.

Comment 6

[David :Bienvenu]

Well, it sounds like if it has a null msg window, it shouldn't set it...

Comment 7

[David :Bienvenu]

Attachment: proposed fix

I'll run with the assertion for a while and see if I hit it unexpectedly - so far, I haven't seen it.

Comment 8

[David :Bienvenu]

fix checked in with assertion still turned on for me - I'll remove it at some point...