481313 - Give aus2 users a unique cookie.

Status: RESOLVED FIXED

(AUS Graveyard :: General, defect)

Description

[Jeremy Orem [:oremj]]

Attachment: Implements unique cookie

Each user that visits aus2 needs to receive a unique cookie.  Currently we do this with mod_usertrack, but it doesn't work very well with proxies.  The patch below is untested (because I don't have a dev copy of aus2 set up), but should do the trick.

Comment 1

[Jeremy Orem [:oremj]]

in the patch s/microtime()/microtime(true)/

Comment 2

[Michael Morgan [:morgamic]]

I have a test env set up here:
http://khan.mozilla.org:8080/VerifyAus

We can apply the patch and see if acceptance tests work.

Comment 3

[Reed Loden [:reed]]

Comment on attachment 365336 [details] [diff] [review]
Implements unique cookie

>+//Are we behind a proxy and given the IP via an alternate enviroment variable? If so, use it.
>+if (!empty($_SERVER["HTTP_X_FORWARDED_FOR"])) {
>+    $ip = $_SERVER["HTTP_X_FORWARDED_FOR"];
>+} else {
>+    $ip = $_SERVER["REMOTE_ADDR"];
>+}

As we found out with bugzilla, $_SERVER["HTTP_X_FORWARDED_FOR"] can be an array of proxy servers, so we need to get the correct IP from it...

Something like this code that I just took from some website:

<?php
function get_ip_list() {
$tmp = array();
if (isset($_server['http_x_forwarded_for']) && strpos($_server['http_x_forwarded_for'],',')) {
$tmp += explode(',',$_server['http_x_forwarded_for']);
} elseif (isset($_server['http_x_forwarded_for'])) {
$tmp[] = $_server['http_x_forwarded_for'];
}
$tmp[] = $_server['REMOTE_ADDR'];
return $tmp;
}
?>

Comment 4

[Michael Morgan [:morgamic]]

Which of the IPs reflects the client IP, though?  That's the one we want.

Comment 5

[Jeremy Orem [:oremj]]

I think this will work:
list($ip) = explode(', ',$_SERVER["HTTP_X_FORWARDED_FOR"]);

Comment 6

[Jeremy Orem [:oremj]]

Attachment: Patch with microtime and multiple IP fix.

Comment 7

[Michael Morgan [:morgamic]]

Comment on attachment 365347 [details] [diff] [review]
Patch with microtime and multiple IP fix.

Looks good to me - passes acceptance tests and cookie issued as required.

Comment 8

[Jeremy Orem [:oremj]]

Justin, when do you want to push this?

Comment 9

[Justin Fitzhugh]

once you guys are satisfied it's ready for production, asap.  would *really* like to get this in blocklist at the same time...but I am pretty sure the patch would be a different animal - separate bug?

Comment 10

[Jeremy Orem [:oremj]]

Blocklist will require a separate patch, but it is blocked on Bug 479070 for now.  Mike tested the patch and it appears to be production ready.  Let's push tomorrow.

Comment 11

[Michael Morgan [:morgamic]]

Checked this into AUS.

Comment 12

[Justin Fitzhugh]

is this tested and ready to go?

Comment 13

[Michael Morgan [:morgamic]]

Yeah, from our end.  Since it involved a header change and acceptance tests passed wasn't feeling that QA needs to spend time on it.  It's tagged for prod.

Comment 14

[Jeremy Orem [:oremj]]

I'll close this bug out.  The production push bug is Bug 480649.

Comment 15

[Jeremy Orem [:oremj]]

Attachment: Makes cookie name and domain configurable.

Comment 16

[Michael Morgan [:morgamic]]

Comment on attachment 365931 [details] [diff] [review]
Makes cookie name and domain configurable.

I'm ok with this, but if someone doesn't update their config file it's gonna bork their AUS install.

Comment 17

[Michael Morgan [:morgamic]]

Acceptance tests still applied, patch was committed and tagged.

Comment 18

[Jeremy Orem [:oremj]]

Attachment: Fix cookie name

Cookie name was hard coded. This patch fixes the issue. Mike, will you commit this patch? I'll update after.

Comment 19

[Reed Loden [:reed]]

Comment on attachment 385329 [details] [diff] [review]
Fix cookie name

r=reed.

I can commit this if you need somebody to.

Comment 20

[Jeremy Orem [:oremj]]

Yes please.

Comment 21

[Reed Loden [:reed]]

Checking in xml/index.php;
/cvsroot/mozilla/webtools/aus/xml/index.php,v  <--  index.php
new revision: 1.24; previous revision: 1.23
done

Tagging now.

Comment 22

[Reed Loden [:reed]]

Tagged, AUS2_PRODUCTION, AUS2_STAGING, AUS2_RTM_200906260000

Comment 23

[Justin Fitzhugh]

Can ops run some tests on the logs to ensure this is fixed before metrics runs a longer test (takes 2-3 days)?  Please post results.

Comment 24

[Jeremy Orem [:oremj]]

(In reply to comment #23)
> Can ops run some tests on the logs to ensure this is fixed before metrics runs
> a longer test (takes 2-3 days)?  Please post results.

Ran several requests and only was issued a new cookie when my browser did not submit one.