Port |Bug 473905 - View All Headers mode leaks DOM nodes| to SeaMonkey

RESOLVED FIXED in seamonkey2.0b1

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({memory-leak})

Trunk
seamonkey2.0b1
memory-leak

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 years ago
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090228 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/f7f62131998d
 +http://hg.mozilla.org/comm-central/rev/7ea34ef19dc4)

I can reproduce this bug.
(Assignee)

Comment 1

9 years ago
Created attachment 365374 [details] [diff] [review]
(Av1) SM fix

This is a copy of the TB patch,
without |gDummyHeaderIdIndex = 0;| which SM doesn't have.


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090228 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/f7f62131998d
 +http://hg.mozilla.org/comm-central/rev/7ea34ef19dc4)

With my test message,
I have 17 persistent nodes,
and 6 that are now added/_removed_ when changing the expand mode :-)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #365374 - Flags: review?(iann_bugzilla)

Comment 2

9 years ago
Comment on attachment 365374 [details] [diff] [review]
(Av1) SM fix

createHeaderEntry should set isNewView to false. (Although personally I'd call it isNewHeader, and move it before isValid).
(Assignee)

Comment 3

9 years ago
Created attachment 365670 [details] [diff] [review]
(Av1a) SM fix

Av1, with comment 2 suggestion(s).
Attachment #365374 - Attachment is obsolete: true
Attachment #365670 - Flags: review?(neil)
Attachment #365374 - Flags: review?(iann_bugzilla)

Updated

9 years ago
Attachment #365670 - Flags: review?(neil) → review+

Comment 4

9 years ago
Comment on attachment 365670 [details] [diff] [review]
(Av1a) SM fix

>+  for (index in headerTable)
Nit: missing var (JS doesn't warn about this, unfortunately, and I'm sorry I didn't notice before, and we've got lots more like this to copy from...)

Comment 5

9 years ago
New function names in msgHdrViewOverlay.js should start with an uppercase letter.

Comment 6

9 years ago
(In reply to comment #5)
> New function names in msgHdrViewOverlay.js should start with an uppercase
> letter.

Shouldn't the argument in the function start with an 'a' too?

Comment 7

9 years ago
Yes.
(Assignee)

Comment 8

9 years ago
Created attachment 365834 [details] [diff] [review]
(Av1b) SM fix
[Checkin: Comment 10]

Av1a, with comment 5 and comment 6 suggestion(s), ++.
Attachment #365670 - Attachment is obsolete: true
Attachment #365834 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 9

9 years ago
(In reply to comment #8)
> Av1a, with comment 5 and comment 6 suggestion(s), ++.

And comment 4 suggestion(s).

Updated

9 years ago
Attachment #365834 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 10

9 years ago
Comment on attachment 365834 [details] [diff] [review]
(Av1b) SM fix
[Checkin: Comment 10]


http://hg.mozilla.org/comm-central/rev/02d487115204
Attachment #365834 - Attachment description: (Av1b) SM fix → (Av1b) SM fix [Checkin: Comment 10]
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.