Closed
Bug 481337
Opened 17 years ago
Closed 17 years ago
Port |Bug 473905 - View All Headers mode leaks DOM nodes| to SeaMonkey
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0b1
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
(Keywords: memory-leak)
Attachments
(1 file, 2 obsolete files)
|
4.17 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090228 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/f7f62131998d
+http://hg.mozilla.org/comm-central/rev/7ea34ef19dc4)
I can reproduce this bug.
|
Assignee | |
Comment 1•17 years ago
|
||
This is a copy of the TB patch,
without |gDummyHeaderIdIndex = 0;| which SM doesn't have.
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090228 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/f7f62131998d
+http://hg.mozilla.org/comm-central/rev/7ea34ef19dc4)
With my test message,
I have 17 persistent nodes,
and 6 that are now added/_removed_ when changing the expand mode :-)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #365374 -
Flags: review?(iann_bugzilla)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 365374 [details] [diff] [review]
(Av1) SM fix
createHeaderEntry should set isNewView to false. (Although personally I'd call it isNewHeader, and move it before isValid).
|
|
Assignee | |
Comment 3•17 years ago
|
||
Av1, with comment 2 suggestion(s).
Attachment #365374 -
Attachment is obsolete: true
Attachment #365670 -
Flags: review?(neil)
Attachment #365374 -
Flags: review?(iann_bugzilla)
|
|
||
Updated•17 years ago
|
Attachment #365670 -
Flags: review?(neil) → review+
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 365670 [details] [diff] [review]
(Av1a) SM fix
>+ for (index in headerTable)
Nit: missing var (JS doesn't warn about this, unfortunately, and I'm sorry I didn't notice before, and we've got lots more like this to copy from...)
|
||
Comment 5•17 years ago
|
||
New function names in msgHdrViewOverlay.js should start with an uppercase letter.
(In reply to comment #5)
> New function names in msgHdrViewOverlay.js should start with an uppercase
> letter.
Shouldn't the argument in the function start with an 'a' too?
|
|
||
Comment 7•17 years ago
|
||
Yes.
|
|
Assignee | |
Comment 8•17 years ago
|
||
Attachment #365670 -
Attachment is obsolete: true
Attachment #365834 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Comment 9•17 years ago
|
||
(In reply to comment #8)
> Av1a, with comment 5 and comment 6 suggestion(s), ++.
And comment 4 suggestion(s).
Attachment #365834 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 10•17 years ago
|
||
Comment on attachment 365834 [details] [diff] [review]
(Av1b) SM fix
[Checkin: Comment 10]
http://hg.mozilla.org/comm-central/rev/02d487115204
Attachment #365834 -
Attachment description: (Av1b) SM fix → (Av1b) SM fix
[Checkin: Comment 10]
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•