Closed Bug 481528 Opened 15 years ago Closed 15 years ago

Figure out what breaks the test for 480149 on the 191 branch and re-enable it

Categories

(Core :: DOM: Navigation, defect, P1)

Product:
Core
Component:
DOM: Navigation
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b3

People

(Reporter: asaf, Assigned: bzbarsky)

References

Details

(Keywords: fixed1.9.1)

Flags: blocking1.9.1?
Summary: Figure out what breaks the test for 480149 on the 191 branch → Figure out what breaks the test for 480149 on the 191 branch and re-enable it
This needs to block, since in particular the test testing core docshell-swapping is now disabled on branch...
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b4pre) Gecko/20090305 Shiretoko/3.1b4pre ID:20090305033203

1. Open window with two tabs
2. URL in second tab => data:text/html,<html><body onbeforeunload='document.documentElement.textContent = "beforeunload"' onunload='document.documentElement.textContent = "unload"' onpagehide='document.documentElement.textContent = "pagehide"'>This is a test</body></html>
3. Drag this tab to content area

Result - new window containing pagehide
Uh... That's wrong.  Very very wrong.  That worksforme on trunk, so this is a serious problem _somewhere_ on branch.
That was NOT the case in 3.1b2.

And in fact, this is what the failing test was all about.  This needs to block b3, since we've just broken web compat, and will break it again before final fixing this bug.
Priority: -- → P1
Target Milestone: --- → mozilla1.9.1b3
Pushed the fix and test re-enable to the branch:

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ab638d51a755
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b5401b3b7b92

That fixes it for 1.9.1.  Still need to push to the relbranch to get it fixed there.
Assignee: nobody → bzbarsky
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Mrking blocking, but this is already fixed on the branch, right? bz, mind adding the appropriate keywords assuming that's the case?
Flags: blocking1.9.1? → blocking1.9.1+
Er, yes.
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.