481579 - changes to shunt and tools for jemalloc on windows ce

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.1

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 365603 [details] [diff] [review]
patch v.1

why:

+#include <wchar.h>

This forces wchar.h to be included by every file.

Can you pull all of the "C" memory functions into an 'extern "C" block' so that you only need to declare these functions once?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.2

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.3

this gets rid of the reference to mozce_coredll

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 366759 [details] [diff] [review]
patch v.3

look okay.  mostly nits.

ooc, what is this change for:

+#define _CRTIMP __declspec(dllexport)

nit:  
ce_wcsndup( const unsigned

No space between the ( and the type.

+ * Portions created by the Initial Developer are Copyright (C) 2008

2009

+mozce_strndup( const char *src, size_t len ) {

check for malloc failure.

same thing for the rest of these functions.


-static bool env_ready = false;
+static bool env_ready = FALSE;

ooc, was this needed?


-  args[i++] = "/Zc:wchar_t-";          //

Why?


   args[i++] = LIB_PATH;
 
   argpath_conv(&argv[1], &args[i]);
-
+  

and

-
+  args[i++] = "/NODEFAULTLIB";
+    
+#ifdef MOZ_MEMORY

kill the whitespace.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #4)
> (From update of attachment 366759 [details] [diff] [review])
> look okay.  mostly nits.
> 
> ooc, what is this change for:
> 
> +#define _CRTIMP __declspec(dllexport)

That is so when we include stdlib, it defines malloc, free etc. with the same linkage as we're using (otherwise its dllimport, which causes and error)


> -  args[i++] = "/Zc:wchar_t-";          //
> 
> Why?

/Zc:whcar_t- is in CFLAGS, defining it here is redundant and confusing if try to you change it

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.4

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.5, quiets compiler warnings

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/4054dd5d4084

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 368888 [details] [diff] [review]
patch v.5, quiets compiler warnings

a191=beltzner

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0ffa6f0d0d40