481732 - Have unit tests (automation.py ones) dump stacks on crashes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Attachment: Run minidump_stackwalk from automation.py, under the right conditions, rev. 1

This patch may be enough to have automation.py-style unit tests dump crash stacks.

Requirements:
* should have already run `make buildsymbols`
* should have MINIDUMP_STACKWALK=/path/to/minidump_stackwalk set in the environment

I'm not sure how/whether it will work with packaged tests... Ted is there a MDC doc on packaged tests?

Comment 1

[(not currently active) Ted Mielczarek]

No, but bug 421611 comment 36 explains how to do it with Mochitest.

Comment 2

[Benjamin Smedberg]

Attachment: Run minidump_stackwalk from automation.py, under the right conditions, rev. 1.1

Minor path fixup discovered during tinderbox testing

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 366015 [details] [diff] [review]
Run minidump_stackwalk from automation.py, under the right conditions, rev. 1.1

+    mkdir $(DIST)/crashreporter-symbols

Should probably be $(NSINSTALL) -D while you're here.

+    cd $(DIST)/crashreporter-symbols && \
           zip -r9D ../../$(SYMBOL_ARCHIVE_BASENAME).zip .

You need to take out one ../ in the zip file name there.

+    log.info("TEST-UNEXPECTED-FAIL | Browser crashed (minidump found)")

can you make this say:
TEST-UNEXPECTED-FAIL | automation.py | Browser crashed (minidump found)

In the tinderbox summary, this should work out ok, right? the crash stack will wind up right below this, and both should wind up in the short log?

It'd be nice if you added cmdline args to runtests.py / runreftest.py to specify the symbol path, since we're gonna need that eventually anyway.

Comment 4

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/a2a7177a218e

Comment 5

[(not currently active) Ted Mielczarek]

Hey, it works:
http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox&errorparser=unittest&logfile=1236887430.1236888099.13857.gz&buildtime=1236887430&buildname=OS%20X%2010.5.2%20mozilla-central%20unit%20test&fulltext=1#err2

Comment 7

[(not currently active) Ted Mielczarek]

Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6d48903f134b