481780 - WINCE define needs to be in ACDEFINE

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Doug Turner (:dougt)]

our Preprocessor.py looks in DEFINES and ACDEFINES for things to filter on.  For example, 

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.xul#60

We would like the preprocessor to see WINCE.  Right now, our tools pass this #define.  we should move this to configure.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

i did not want to touch the tools.  they are a wicked mess when it comes to defining things that configure should.  this fixes the immediate problem.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 365823 [details] [diff] [review]
patch v.1

+    AC_SUBST(WINCE)

This doesn't have any effect unless you stick:
WINCE = @WINCE@
in autoconf.mk.in.

Also, the AC_SUBST bits should really go down at the bottom of configure with all the others. Otherwise, they won't get substituted on other platforms.

Comment 3

[Doug Turner (:dougt)]

wierd, huh.  it is already in the autoconf.mk.in:

http://mxr.mozilla.org/mozilla-central/search?string=%40WINCE%40&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

should both AC_SUBST go to the bottom?  WINCE and WINCE_WINDOWS_MOBILE

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 5

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/522eb5aff398

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 365937 [details] [diff] [review]
patch v.2

a191=beltzner

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/59ebaed79dc6

Comment 8

[Serge Gautherie (:sgautherie)]

It seems this duplicated |AC_SUBST(WINCE)| :-/
http://mxr.mozilla.org/mozilla-central/search?string=AC_SUBST%5C%28WINCE%5C%29&regexp=on&case=on&find=%2Fconfigure%5C.in%24

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Un-duplicate |AC_SUBST(WINCE)| [Checkin: Comment 10]

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 386425 [details] [diff] [review]
(Bv1) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 10]


http://hg.mozilla.org/mozilla-central/rev/cdeb147ed5f7

Comment 11

[Samuel Sidler (old account; do not CC)]

Comment on attachment 386425 [details] [diff] [review]
(Bv1) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 10]

aiui, this is no longer needed for 1.9.1 since Fennec is shipping off 1.9.2. Please re-nom if that's not correct.

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 386425 [details] [diff] [review]
(Bv1) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 10]


I don't know about Fennec,
but I would like it to sync' from it in bug 496236.

Comment 13

[Samuel Sidler (old account; do not CC)]

Comment on attachment 386425 [details] [diff] [review]
(Bv1) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 10]

Mobile patches don't need to land for 1.9.1, aiui. Please renom if I'm missing something.

Comment 14

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-CC) Un-duplicate |AC_SUBST(WINCE)| [Checkin: Comment 15]

(In reply to comment #12)
> sync' from it in bug 496236.

Do it for bug 506493 now that c-1.9.1 has branched.

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 423356 [details] [diff] [review]
(Cv1-CC) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 15]


http://hg.mozilla.org/comm-central/rev/bd00021f2b0f