Closed Bug 481780 Opened 11 years ago Closed 11 years ago

WINCE define needs to be in ACDEFINE

Categories

(Firefox Build System :: General, defect)

x86
Windows CE
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dougt, Assigned: dougt)

References

Details

(Keywords: fixed1.9.1)

Attachments

(3 files, 1 obsolete file)

our Preprocessor.py looks in DEFINES and ACDEFINES for things to filter on.  For example, 

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.xul#60

We would like the preprocessor to see WINCE.  Right now, our tools pass this #define.  we should move this to configure.
Attached patch patch v.1 (obsolete) — Splinter Review
i did not want to touch the tools.  they are a wicked mess when it comes to defining things that configure should.  this fixes the immediate problem.
Attachment #365823 - Flags: review?(ted.mielczarek)
Comment on attachment 365823 [details] [diff] [review]
patch v.1

+    AC_SUBST(WINCE)

This doesn't have any effect unless you stick:
WINCE = @WINCE@
in autoconf.mk.in.

Also, the AC_SUBST bits should really go down at the bottom of configure with all the others. Otherwise, they won't get substituted on other platforms.
wierd, huh.  it is already in the autoconf.mk.in:

http://mxr.mozilla.org/mozilla-central/search?string=%40WINCE%40&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

should both AC_SUBST go to the bottom?  WINCE and WINCE_WINDOWS_MOBILE
Attached patch patch v.2Splinter Review
Attachment #365823 - Attachment is obsolete: true
Attachment #365937 - Flags: review?(ted.mielczarek)
Attachment #365823 - Flags: review?(ted.mielczarek)
Attachment #365937 - Flags: review?(ted.mielczarek) → review+
Attachment #365937 - Flags: approval1.9.1?
http://hg.mozilla.org/mozilla-central/rev/522eb5aff398
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #365937 - Flags: approval1.9.1? → approval1.9.1+
Depends on: 474737
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Attachment #386425 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 386425 [details] [diff] [review]
(Bv1) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 10]


http://hg.mozilla.org/mozilla-central/rev/cdeb147ed5f7
Attachment #386425 - Attachment description: (Bv1) Un-duplicate |AC_SUBST(WINCE)| → (Bv1) Un-duplicate |AC_SUBST(WINCE)| [Checkin: Comment 10]
Attachment #386425 - Flags: approval1.9.1.1?
Attachment #386425 - Flags: approval1.9.1.1? → approval1.9.1.2?
Comment on attachment 386425 [details] [diff] [review]
(Bv1) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 10]

aiui, this is no longer needed for 1.9.1 since Fennec is shipping off 1.9.2. Please re-nom if that's not correct.
Attachment #386425 - Flags: approval1.9.1.2?
Comment on attachment 386425 [details] [diff] [review]
(Bv1) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 10]


I don't know about Fennec,
but I would like it to sync' from it in bug 496236.
Attachment #386425 - Flags: approval1.9.1.2?
Comment on attachment 386425 [details] [diff] [review]
(Bv1) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 10]

Mobile patches don't need to land for 1.9.1, aiui. Please renom if I'm missing something.
Attachment #386425 - Flags: approval1.9.1.2?
(In reply to comment #12)
> sync' from it in bug 496236.

Do it for bug 506493 now that c-1.9.1 has branched.
Attachment #423356 - Flags: review?(bugspam.Callek)
No longer blocks: C191ConfSync
Attachment #423356 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 423356 [details] [diff] [review]
(Cv1-CC) Un-duplicate |AC_SUBST(WINCE)|
[Checkin: Comment 15]


http://hg.mozilla.org/comm-central/rev/bd00021f2b0f
Attachment #423356 - Attachment description: (Cv1-CC) Un-duplicate |AC_SUBST(WINCE)| → (Cv1-CC) Un-duplicate |AC_SUBST(WINCE)| [Checkin: Comment 15]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.