481850 - Port Bug 480893 (Session Restore, start new session does not follow startup page option) to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch

After selecting "New Session" from Session Restore dialog, the browser opens my
homepage in a new tab, rather than following my configuration to open a blank
tab on startup.

Reproducible: Always

Steps to Reproduce:
1. Set pref to open a blank page on startup.
2. Click New Session from within session restore dialog

Actual Results:  
Opens home page url

Expected Results:  
Opens a blank tab

Comment 1

[[e-mail]]

What happens if the browser is set to restore previous session?

Comment 2

[Misak Khachatryan]

Hmm, good question. In firefox code is simple :
-  getBrowserWindow().BrowserHome();
+  var prefBranch =
Cc["@mozilla.org/preferences-service;1"].getService(Ci.nsIPrefBranch);
+  if (prefBranch.getIntPref("browser.startup.page") == 0)
+    getBrowserWindow().gBrowser.loadURI("about:blank");
+  else
+    getBrowserWindow().BrowserHome();

So it opens home page for everything but blank pref. It's up to us what to pick
- blank or home page. Please advise.

Comment 3

[[e-mail]]

I can't decide. Maybe jag can help me out here ;-)

Comment 4

[jag (Peter Annema)]

Well, the patch is missing a case. If the pref is set to 3 (restore previous session) we'll end up doing nothing at all. Which is fine, actually, I think loading nothing so we end up with a blank page is the right thing to do. I'd also do it for case 2 (last page visited) since the user just declined to restore it (and all the other pages) from the previous session.

Also, I don't think we need to load about:blank explicitly, so something like this:

  if (Components.classes["@mozilla.org/preferences-service;1"]
                .getService(Components.interfaces.nsIPrefBranch)
                .getIntPref("browser.startup.page") == 1)
    getBrowserWindow().BrowserHome();

Comment 5

[jag (Peter Annema)]

  else
    getBrowserWindow().gBrowser.loadURI("about:blank");

Comment 6

[jag (Peter Annema)]

('coz we don't want to leave the user on about:sessionrestore, as Neil pointed out to me)

Comment 7

[Misak Khachatryan]

Attachment: jag's comments addressed

Comment 8

[[e-mail]]

Comment on attachment 366173 [details] [diff] [review]
jag's comments addressed

>+    getBrowserWindow().gBrowser.loadURI("about:blank");
Nit: I'd prefer .getBrowser(). instead of .gBrowser.

Comment 9

[Misak Khachatryan]

Attachment: for checkin

Carrying forward r+/sr+ from jag/Neil, nit fixed.

Comment 10

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/bdcefed8ee39