481958 - Correct relationship between sort marker/arrow and sort direction in Cookie Manager

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

In bug 476175 it was noticed that the sort marker/arrow is always pointing in the wrong direction. Example: By default the tree is sorted ascending by Site (host) but the sort marker shows the opposite (descending order). The mentioned bug didn't change that, it has been like that before.

The sortDirection attribute of the domainCol (cookieViewer.xul) needs to be switched to "ascending" as part of this bug but it's not enough: clicking any column header (clicking the same again to switch the sort direction) will show that the actual problem lies in the sorting code (cookieViewer.js, probably CookieColumnSort(), maybe SortTree()).

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: proposed patch [Checkin: Comment 4]

Regarding CookieColumnSort():
In the beginning of the function lastCookieSortAscending is actually the last sort direction but after SortTree() has been called it's the new (possibly same) sort direction. That's why the old sortDirection attribute setting logic needs to be reversed.

Comment 2

[[e-mail]]

Comment on attachment 367465 [details] [diff] [review]
proposed patch
[Checkin: Comment 4]

Actually, I didn't think to check the allowed/blocked hosts list; it might have the same problem.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #2)
> (From update of attachment 367465 [details] [diff] [review])
> Actually, I didn't think to check the allowed/blocked hosts list; it might have
> the same problem.

It does but I'll address all of that (sorting arrows, adding a confirmation
dialog for deleting multiple permissions) in bug 483516.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 367465 [details] [diff] [review]
proposed patch
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/9554b8d220ed