Force logging on in imagelib

RESOLVED FIXED in mozilla8

Status

()

Core
ImageLib
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Justin Lebar (not reading bugmail))

Tracking

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Created attachment 366032 [details] [diff] [review]
Force logging in build rather than in code

We need to have logging forced on, even in release builds. It's impossible to debug problems users have without it.
Attachment #366032 - Flags: review?(vladimir)
Comment on attachment 366032 [details] [diff] [review]
Force logging in build rather than in code

I don't think you even need the ifneq bit.. no reason not to just -DFORCE_PR_LOG unconditionally
Attachment #366032 - Flags: review?(vladimir) → review+
(Reporter)

Comment 2

8 years ago
Created attachment 366333 [details] [diff] [review]
Force logging everywhere in build

Turns out we need to add the logging bit to just about every Makefile.

Are you sure about -DFORCE_PRLOG everywhere, regardless of whether MOZ_LOGGING is on? Are we going to run into build problems in a build where logging is forced off?
Assignee: nobody → joe
Attachment #366032 - Attachment is obsolete: true
Attachment #366333 - Flags: review?(vladimir)
Comment on attachment 366333 [details] [diff] [review]
Force logging everywhere in build

I don't see how it would, but ask ted?
Attachment #366333 - Flags: review?(vladimir) → review+
The only point of MOZ_LOGGING, it would appear, is to control whether various modules define FORCE_PR_LOG. It looks like everywhere else in the tree just does:
#if defined(MOZ_LOGGING)
#define FORCE_PR_LOG
#endif

http://mxr.mozilla.org/mozilla-central/search?string=MOZ_LOGGING

Do you not have a central header you could do this in? If not, maybe instead you could add MOZ_LOGGING=1 here:
http://mxr.mozilla.org/mozilla-central/source/configure.in#6461

and then AC_SUBST(MOZ_LOGGING) down with the other AC_SUBST bits, add it to autoconf.mk.in, and just use it as a makefile var:
ifdef MOZ_LOGGING
...
endif
(Assignee)

Comment 5

6 years ago
Is this still something we want?  I'd kind of like it for bug 666352 (although there, I really only care about having it on during my custom release builds, not official builds).
(Reporter)

Comment 6

6 years ago
Yes, we definitely still want this.
(Assignee)

Updated

6 years ago
Assignee: joe → justin.lebar+bug
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 7

6 years ago
Created attachment 544848 [details] [diff] [review]
Patch v1

This forces logging on within ImageLogging.h.  This is similar to how nsHttp.h works.
Attachment #544848 - Flags: review?(joe)
(Assignee)

Updated

6 years ago
Attachment #366333 - Attachment is obsolete: true
(Reporter)

Comment 8

6 years ago
Comment on attachment 544848 [details] [diff] [review]
Patch v1

If'n this passes try, hooray!
Attachment #544848 - Flags: review?(joe) → review+
(Assignee)

Comment 9

6 years ago
Try push: http://hg.mozilla.org/try/rev/144138c0b56d
(Assignee)

Comment 10

6 years ago
Inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/0c69c4d8e19e
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/0c69c4d8e19e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.