482020 - Undefined accesskey should not be "undefined"

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Atsushi Sakai]

Attachment: screenshot showing problem

Please see the attached screenshot of DOM Inspector showing problem.
The accesskey's value "undefined" is strange.

This has happened after Bug 474093 landing.

I'll attach a patch.

Comment 1

[Atsushi Sakai]

Attachment: Patch v1.0

Comment 2

[James Ross]

1. There was absolutely no need to file a whole new bug for this - it's a minor problem with the bug's patch, which isn't in any released versions.
2. Including "ChatZilla" in the summary when the bug is in the ChatZilla component is stupid.

Comment 3

[James Ross]

Comment on attachment 366090 [details] [diff] [review]
Patch v1.0

>     var rv = getAccessKey(window[labelString]);
>     if (!rv)
>         rv = window[labelString + "_ACCESSKEY"];
>-    return rv;
>+    return rv ? rv : "";

getAccessKey() already returns "" if there isn't one, so I'd rather just ensure line 3 is a string result, e.g.:

>         rv = window[labelString + "_ACCESSKEY"] || "";

Or perhaps:

>     if (!rv && ((labelString + "_ACCESSKEY") in window))
>         rv = window[labelString + "_ACCESSKEY"];

Comment 4

[Atsushi Sakai]

Attachment: Patch rv1.1

Addresses comment.

(In reply to comment #2)
Sorry for not knowing the rules.

Comment 5

[James Ross]

Comment on attachment 366171 [details] [diff] [review]
Patch rv1.1

Thanks, r=silver.

Comment 6

[James Ross]

Checked in --> FIXED.