Closed
Bug 482020
Opened 16 years ago
Closed 16 years ago
Undefined accesskey should not be "undefined"
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dev-null, Assigned: dev-null)
References
Details
(Keywords: regression, Whiteboard: [cz-0.9.85])
Attachments
(2 files, 1 obsolete file)
130.31 KB,
image/png
|
Details | |
811 bytes,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
Please see the attached screenshot of DOM Inspector showing problem.
The accesskey's value "undefined" is strange.
This has happened after Bug 474093 landing.
I'll attach a patch.
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #366090 -
Flags: review?(silver)
Comment 2•16 years ago
|
||
1. There was absolutely no need to file a whole new bug for this - it's a minor problem with the bug's patch, which isn't in any released versions.
2. Including "ChatZilla" in the summary when the bug is in the ChatZilla component is stupid.
Summary: [ChatZilla] Undefined accesskey should not be "undefined" → Undefined accesskey should not be "undefined"
Comment 3•16 years ago
|
||
Comment on attachment 366090 [details] [diff] [review]
Patch v1.0
> var rv = getAccessKey(window[labelString]);
> if (!rv)
> rv = window[labelString + "_ACCESSKEY"];
>- return rv;
>+ return rv ? rv : "";
getAccessKey() already returns "" if there isn't one, so I'd rather just ensure line 3 is a string result, e.g.:
> rv = window[labelString + "_ACCESSKEY"] || "";
Or perhaps:
> if (!rv && ((labelString + "_ACCESSKEY") in window))
> rv = window[labelString + "_ACCESSKEY"];
Attachment #366090 -
Flags: review?(silver) → review-
Assignee | ||
Comment 4•16 years ago
|
||
Addresses comment.
(In reply to comment #2)
Sorry for not knowing the rules.
Attachment #366090 -
Attachment is obsolete: true
Attachment #366171 -
Flags: review?(silver)
Comment 5•16 years ago
|
||
Comment on attachment 366171 [details] [diff] [review]
Patch rv1.1
Thanks, r=silver.
Attachment #366171 -
Flags: review?(silver) → review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 6•16 years ago
|
||
Checked in --> FIXED.
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [cz-0.9.85]
You need to log in
before you can comment on or make changes to this bug.
Description
•