Closed
Bug 482065
Opened 16 years ago
Closed 15 years ago
Allow rearranging of thumbnails in the all tabs panel
Categories
(Firefox :: Tabbed Browser, enhancement)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 3.7a1
People
(Reporter: tdowner, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
2.23 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
If you wish to drag and drop to rearrange the previews in the tab preview window, it should do so. Also, it should match the rearrangement by moving the tabs on the tab bar.
Assignee | ||
Updated•15 years ago
|
Blocks: ctrl-tab-panel
Assignee | ||
Updated•15 years ago
|
Summary: Allow rearranging of Thumbnails in Tab Preview → Allow rearranging of thumbnails in the all tabs panel
Assignee | ||
Comment 2•15 years ago
|
||
This was surprisingly trivial, thanks to the solid drag and drop API and due to the fact that browser-tabPreviews.js handled the TabMove event already.
Oh, so then it is a duplicate. Wow, I thought you would never get to this! Thanks :)
Comment 5•15 years ago
|
||
Comment on attachment 421818 [details] [diff] [review]
patch
>+ <handler event="dragover"><![CDATA[
>+ if (event.dataTransfer.types.contains("application/x-moz-node"))
You may want to check the (tab.parentNode == gBrowser.tabContainer) condition here in the dragover listener as well.
>+ <handler event="drop"><![CDATA[
>+ let tab = event.dataTransfer.mozGetDataAt("application/x-moz-node", 0);
>+ if (tab && tab.parentNode == gBrowser.tabContainer) {
>+ let newIndex = Array.indexOf(gBrowser.tabContainer.childNodes, this._tab);
>+ gBrowser.moveTabTo(tab, newIndex);
>+ }
>+ ]]></handler>
Is there a gap between or at the ends of the preview buttons where the user might want to drop? The above would only support dropping right on another button, no?
Assignee | ||
Comment 6•15 years ago
|
||
(In reply to comment #5)
> You may want to check the (tab.parentNode == gBrowser.tabContainer) condition
> here in the dragover listener as well.
Makes sense.
> Is there a gap between or at the ends of the preview buttons where the user
> might want to drop? The above would only support dropping right on another
> button, no?
There are no gaps between the previews. There can be space at the end; for instance, if there were 7 previews in 3 rows, there would be two empty slots. However, the previews' container doesn't have a visible border, so it would probably feel odd if the drop zone equaled the container.
Attachment #421818 -
Attachment is obsolete: true
Attachment #422821 -
Flags: review?(enndeakin)
Attachment #421818 -
Flags: review?(mconnor)
Updated•15 years ago
|
Attachment #422821 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Reporter | ||
Comment 8•15 years ago
|
||
V Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a2pre) Gecko/20100206 Minefield/3.7a2pre ID:20100206050229
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•