482108 - "Invalid alarm for item" errors when reading alarms from older releases

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: sample file from sunbird 0.5

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090307 Calendar/1.0pre

When opening or importing an ics file that contains events/tasks created with Sunbird 0.5 many errors occur like:

[JavaScript Error: "Invalid alarm for item: df402b62-471d-4936-9467-8128a772f700 (BEGIN:VALARM
TRIGGER;VALUE=DURATION:-PT15M
X-MOZ-LASTACK:20090224T155710Z
DESCRIPTION:Mozilla Alarm: dismissed alarm before
ACTION:DISPLAY
END:VALARM
)"]

Steps to Reproduce:
1. Start with clean profile
2. Import the attached sample file
3. Check Tools > Error Console

Actual Results:
Error message mentioned above is logged for 8 different events/tasks.

Expected Results:
No errors.

Comment 1

[Stefan Sitter [:ssitter]]

Works fine in Sunbird 0.9 -> Regression.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 369809 [details] [diff] [review]
Fix - v1

r- for this one, daniel reviewed the checked in patch over my shoulder.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/054adad6539d>

-> FIXED