482152 - this.mParentItem is null when start Thunderbird

Status: RESOLVED WORKSFORME

(Calendar :: Lightning Only, defect)

Description

[Pete Riley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.7) Gecko/2009021910 Firefox/3.0.7 (.NET CLR 3.5.30729)
Build Identifier: TB3.0b2 / Lightning 1.0pre 2009-03-07

I have the following errors in the console after I start Thunderbird:

Error: this.mParentItem is null
Source File: file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calItemBase.js
Line: 400

(repeats four more times, then:)

Error: [Exception... "'[JavaScript Error: "this.mParentItem is null" {file: "file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calItemBase.js" line: 447}]' when calling method: [calIItemBase::getAttendeeById]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calProviderUtils.jsm :: cPB_getInvitedAttendee :: line 731"  data: yes]

Error: Assert failed: [Exception... "'[JavaScript Error: "this.mParentItem is null" {file: "file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calItemBase.js" line: 400}]' when calling method: [calIItemBase::title]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://calendar/content/calendar-view-core.xml :: setEditableLabel :: line 176"  data: yes]
2: [file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js:440] anonymous
3: [null:0] null
4: [chrome://calendar/content/agenda-listbox.js:601] refreshCalendarQuery
5: [chrome://calendar/content/agenda-listbox.js:662] refreshPeriodDates
6: [chrome://calendar/content/today-pane.js:263] updatePeriod
7: [chrome://calendar/content/today-pane.js:229] setDay
8: [chrome://calendar/content/today-pane.js:191] setDaywithjsDate
9: [chrome://messenger/content/messenger.xul:1] onchange
10: [chrome://calendar/content/widgets/minimonth.xml:871] fireEvent
11: [chrome://calendar/content/widgets/minimonth.xml:1001] update

Source File: file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js
Line: 968

(repeats once, then:)

Error: Assert failed: [Exception... "'[JavaScript Error: "this.mParentItem is null" {file: "file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calItemBase.js" line: 622}]' when calling method: [calIItemBase::getCategories]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://calendar/content/calendar-view-core.xml :: setCSSClasses :: line 189"  data: yes]
2: [file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js:440] anonymous
3: [null:0] null
4: [chrome://calendar/content/agenda-listbox.js:601] refreshCalendarQuery
5: [chrome://calendar/content/agenda-listbox.js:662] refreshPeriodDates
6: [chrome://calendar/content/today-pane.js:263] updatePeriod
7: [chrome://calendar/content/today-pane.js:229] setDay
8: [chrome://calendar/content/today-pane.js:120] initializeMiniday
9: [chrome://calendar/content/today-pane.js:54] onLoad
10: [chrome://calendar/content/today-pane.js:315] loadTodayPane

Source File: file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///C:/Data/Databases/Thunderbird/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js
Line: 968

This happens with a local ics file (using file:///).
This problem is not new with the 2009-03-07 nightly (also happens with 2009-03-05, for example).

Reproducible: Sometimes

Steps to Reproduce:
1. Create a new network calendar (file:///) using the ics file that I'll attach in my next post.

Actual Results:  
errors

Comment 1

[Pete Riley]

Attachment: ICS file that causes the errors

Comment 2

[Pete Riley]

STR:  Step 2:  Restart Thunderbird

Comment 3

[Pete Riley]

It's possibly related to the rrule in event "Five":

RRULE:FREQ=YEARLY;BYDAY=2SU;BYMONTH=3

That's when the U.S. starts Daylight Savings Time, and that is today.  So it might or might not be related to DST.

If I change the BYMONTH to 2 then there are no errors.  If I set it to 3 or 4 then there are errors.

Revised STR:

1) Change the BYMONTH of event five in the ICS file to a future month.
2) Add the previously attached ics file as a new network calendar (file:///).
3) Restart Thunderbird

FWIW, if I delete and re-add event five, there are no errors.  The problem seems to be related to its position in the file.  I also saw no errors after adding/deleting some other, unrelated events.  Very strange.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Daniel (or anyone else), can you confirm this behavior? If so, I'd say its blocking.

Comment 5

[Stefan Sitter [:ssitter]]

Works for me using Lightning 1.0pre (BuildID: 20090309033613) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090309 Shredder/3.0b3pre (BuildID: 20090309032055). No errors are logged to console. I tested with both BYMONTH=3 and BYMONTH=4 for event "five" as described in comment #3.

Comment 6

[Pete Riley]

I just discovered another thing.  I can't reproduce it if I set Lightning's timezone to Europe/Berlin, but I can if I set it to America/New York (and restart TB).

It doesn't matter if my OS timezone is set to U.S. or Germany.

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Lets investigate this for 1.0

Comment 8

[Daniel Boelzle [:dbo]]

WFM, too. Pete, could you please try to narrow down the regression range.
I've had a look at the code, but couldn't find any obvious problem where both mIsProxy is set and mParentItem is not set. Moreover the calendar looks pretty simple, no overridden items or the like.

Comment 9

[Pete Riley]

I apologize for not trying this sooner.  I disabled my extensions one by one and believe that the problem is the Thunderbird extension called "DOM Inspector 2.0.3" (https://addons.mozilla.org/en-US/thunderbird/addon/6622).

I noticed the following code in dom_inspector-2.0.3-fx+tb+sb+sm+fn.xpi\chrome\inspector.jar\content\inspector\extensions\treeEditable.xml:

<binding id="treecellEditable" extends="chrome://global/content/bindings/tree.xml#treecell">
    <implementation>
      <property name="parentItem" readonly="true"><![CDATA[
        var parent = this.parentNode;
        while (parent.localName != "treeitem" && parent) {
          parent = parent.parentNode;
        }
        this.mParentItem = parent;
        this.mParentItem;
      ]]></property>

If that's the problem then I think it's a little scary that two different extensions that happen to use the same variable name end up sharing a common variable!  :)  Of course my analysis could be completely wrong.

It's strange that the problem only happens with such a specific .ics file, the America/New York timezone, and the BYMONTH has to be in the future.  These things seem completely unrelated to the DOM Inspector, but apparently there's a subtle conflict somewhere.

Anyway I've disabled the DOM Inspector and that "fixes" the problem.  So, as far as I'm concerned, you can close this bug if you want.

FWIW, I used the DOM Inspector + the InspectorWidget extensions together because it was so easy to identity things in Thunderbird and Lightning that I could control in my userchrome.css.  Oh well.

Comment 10

[Pete Riley]

I can no longer reproduce this bug even if I try to make my environment exactly how it was when I reported the bug.  Honestly I don't want to spend any more time on it unless it happens again.

Comment 11

[Daniel Boelzle [:dbo]]

resolving per comment #10