482156 - Get rid of (unnecessary) LIBGNOME dependency.

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Antonio Gomes (tonikitoo)]

Currently toolkit/system/gnome/ just builds if both GNOMEVFS, GCONF and LIBGNOME dev files are available. About the later requirement (libgnome) it is just needed because there is a single method used from that lib: "gnome_url_show" , which is called from nsGnomeVFSService::ShowURI [1] and nsGnomeVFSService::ShowURIForInput [2].

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/system/gnome/nsGnomeVFSService.cpp#262
[2] http://mxr.mozilla.org/mozilla-central/source/toolkit/system/gnome/nsGnomeVFSService.cpp#274

however having LIBGNOME as a requirement to build "libmozgnome.so" make this module (and consequently both NS_GNOMEVFSSERVICE_CONTRACTID and NS_GCONFSERVICE_CONTRACTID services) unavailable in MAEMO platform (where libgnome is not available).

looking at |gnome_url_show| method body (@ libgnome-2.24.1/libgnome/gnome-url.c) it just forwards a call to "gnome_vfs_url_show_with_env", so we could replace the former by the later w/out losing any functionality, which would make it possible for us to get rid of LIBGNOME as a dep of libmozgnome AND make libmozgnome available in MAEMO.

Comment 1

[Antonio Gomes (tonikitoo)]

Attachment: v0.1 - get rid of libgnome dep to build libmozgnome

Comment 2

[Antonio Gomes (tonikitoo)]

Attachment: v0.11 - get rid of libgnome dep to build libmozgnome

same as previous 0.1 patch PLUS required changes in config/autoconf.mk.in

Comment 3

[Antonio Gomes (tonikitoo)]

added mobile keyword, as it involves maemo (sorta)

Comment 4

[Benjamin Smedberg]

Comment on attachment 366230 [details] [diff] [review]
v0.11 - get rid of libgnome dep to build libmozgnome

This looks fine from a build perspective... I don't know gnomevfs, so I'd like roc or somebody who knows gnomevfs to review the nsGnomeVFSService.cpp change.

Comment 5

[Antonio Gomes (tonikitoo)]

changeset:   25956:175cb4051eb2