Closed
Bug 48217
Opened 24 years ago
Closed 24 years ago
Context menu item "Show in new window" does not use XML Base for XLink
Categories
(Core :: XML, defect, P3)
Core
XML
Tracking
()
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: hjtoi-bugzilla, Assigned: jst)
References
Details
(Whiteboard: [HAVE FIX])
Attachments
(1 file)
3.76 KB,
patch
|
Details | Diff | Splinter Review |
The Show in new window menu item only grabs the href of the simple XLink and
does not use XML Base nor HTML BASE.
There are two immediate solution and one long term solution:
1) Duplicate the C++ code in JS that makes use of XML Base (the C++
code gets executed with show="new" aatribute when you click the
link normally). Slow/bad. This is standards compliant.
2) Create a function thruogh which the JS code can get the the XML Base
computed by C++ code. Fast. Not standards compliant.
3) DOM3 is going to address XML Base. Wait for what DOM3 says.
Reporter | ||
Comment 1•24 years ago
|
||
Since XML is still pretty rare on the web and XML Base even more so, I am
inclined to Future this bug. I want to fix this by using the Base property that
will hopefully make it into DOM3.
This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Reporter | ||
Updated•24 years ago
|
Target Milestone: Future → mozilla0.9
Reporter | ||
Comment 2•24 years ago
|
||
Reporter | ||
Comment 3•24 years ago
|
||
With the baseURI property this indeed becomes quite simple. I fixed some other
cases where we benefit from baseURI property as well. Are there others?
Whiteboard: [fixinhand]
Comment 4•24 years ago
|
||
this is awesome. adding sicking, because his stuff that I'm about to check in
would use this. Sicking - I'll check your stuff in anyway today, but I'm hoping
for an additional patch for using .baseURI in bug 1995
Comment 5•24 years ago
|
||
by the way, sr=alecf :)
Comment 6•24 years ago
|
||
cool. r=blake
Reporter | ||
Comment 7•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•24 years ago
|
||
Reopening 'cos baseURI got backed out. Will reassign to jst who can enable this
again once the DOM conversion branch lands.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla0.9 → mozilla0.9.1
Reporter | ||
Comment 9•24 years ago
|
||
Please enable this fix once the DOM conversion lands.
Assignee: heikki → jst
Status: REOPENED → NEW
Assignee | ||
Updated•24 years ago
|
Whiteboard: [fixinhand] → [fixinhand][XPCDOM]
Assignee | ||
Updated•24 years ago
|
Whiteboard: [fixinhand][XPCDOM] → [HAVE FIX]
Assignee | ||
Comment 10•24 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Comment 12•24 years ago
|
||
Marking verified as per above developer comments.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•