482171 - Replace nsIPref with nsIPrefBranch in embedding tree

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Makoto Kato [:m_kato]]

embedding tree uses nsIPref interface.  We should replace it with nsIPrefBranch and nsIPrefService.

/embedding/qa/testembed/StdAfx.h (View Hg log or Hg annotations)
    * line 89 -- #include "nsIPref.h"
/embedding/browser/photon/src/EmbedPrivate.h (View Hg log or Hg annotations)
    * line 57 -- #include <nsIPref.h>
/embedding/browser/photon/src/nsPrintSettingsImpl.cpp (View Hg log or Hg annotations)
    * line 43 -- #include "nsIPref.h"
/embedding/browser/gtk/src/gtkmozembed_common.cpp (View Hg log or Hg annotations)
    * line 56 -- #include "nsIPref.h"

Comment 1

[Makoto Kato [:m_kato]]

Attachment: patch v1

Comment 2

[Makoto Kato [:m_kato]]

Attachment: patch v2

we cannot test QNX embeded code because we don't have QNX and I think QNX code is broken on m-c tree.

Comment 3

[Benjamin Smedberg]

Comment on attachment 390722 [details] [diff] [review]
patch v2

I think we can remove embedding/qa completely, it hasn't been built in ages. I don't want to review photon code... it doesn't block removing nsIPref though!

Comment 4

[Makoto Kato [:m_kato]]

Since Benjamin removed embedding/qa, I changed platform to QNX neutrino.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: patch v3

no one maintains photon (QNX) code from Gecko 1.8.x release.  I think that this should be removed...

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> Created an attachment (id=413507) [details]
> patch v3

Missed to request review?


Ftr,
http://mxr.mozilla.org/mozilla-central/search?string=nsIPref%5B%5EBLSe%5D&regexp=1&case=1&find=%2Fembedding%2Fbrowser%2Fphoton%2Fsrc%2F
Found 17 matching lines in 4 files
http://mxr.mozilla.org/mozilla-central/search?string=photon
Found 116 matching lines in 41 files

Comment 7

[Makoto Kato [:m_kato]]

forgot this!(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=413507) [details] [details]
> > patch v3
> 
> Missed to request review?

I forgot this!

Comment 8

[Makoto Kato [:m_kato]]

landed
http://hg.mozilla.org/mozilla-central/rev/2f07047e029e