482182 - " Files" portion of HTML Complete save process is not localizable

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Chris Lawson (gone)]

Attachment: fix v1.0

Dave Haas commented way back in the day that it should be, but nobody ever got around to it. Since I was cleaning up SaveHeaderSniffer anyway, I figured I'd go ahead and fix this while I was at it.

The other changes besides the added line in localizable.strings.in were things Smokey asked me to fix while I was in there, just moving things around and the like.

Comment 1

[Stuart Morgan]

Comment on attachment 366255 [details] [diff] [review]
fix v1.0

>+      NSString* htmlCompleteFolderName = [NSString stringWithFormat:@"%@ %@",

This is too English-centric; it assumes all languages will use the same word order. The format string should be @"%@ Format", localized.

Comment 2

[Chris Lawson (gone)]

Attachment: fix v1.01

Addresses comment 1.

Comment 3

[Christopher Henderson]

Comment on attachment 366456 [details] [diff] [review]
fix v1.01

Works fine. Though as Stuart alluded to, this may not always be a suffix string.

Comment 4

[Chris Lawson (gone)]

(In reply to comment #3)
> (From update of attachment 366456 [details] [diff] [review])
> Works fine. Though as Stuart alluded to, this may not always be a suffix
> string.

Which is why the whole string is now localizable ;)

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 366456 [details] [diff] [review]
fix v1.01

sr=pink

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.