The default bug view has changed. See this FAQ.

[Port Bug 479899 to SeaMonkey Modern] s/#autoscroller/.autoscroller/g

RESOLVED FIXED in seamonkey2.1a2

Status

SeaMonkey
Themes
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Philip Chee, Assigned: ewong)

Tracking

({modern})

Trunk
seamonkey2.1a2
modern

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
> There are a number of places in the toolkit theme where id selectors are
> used for some reason. These should be investigated and moved/removed.

> On all platforms, the #autoscroller should be a class.

Comment 1

8 years ago
Note: a) at least for our purposes, the id is being retained
b) there's no indication that the patch will land on branch.
(Reporter)

Comment 2

8 years ago
I don't see where we use #autoscroller ?
<http://mxr.mozilla.org/comm-central/search?string=autoscroller>
(Reporter)

Comment 3

8 years ago
Oh I missed /mozilla/toolkit/content/widgets/browser.xml.

So what happens when we have nightly trunk builds but haven't branched comm-central?

Comment 4

8 years ago
So, I misread the code, and even if we ported bug 386949 that would fix autoscrolling only in tabbrowser, not in other windows.

Presumably to support both sorts of builds we'd need both selectors.

Comment 5

8 years ago
(In reply to comment #3)
> So what happens when we have nightly trunk builds but haven't branched
> comm-central?

We have no plans to do that, so far. (Just as a note)

Comment 6

7 years ago
We've branched, so this can be fixed properly now!
Keywords: helpwanted
Whiteboard: [good first bug]
(Assignee)

Updated

7 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
(Assignee)

Comment 7

7 years ago
Created attachment 448002 [details] [diff] [review]
Changed #autoscroller to .autoscroller in global.css [Checkin: comment 8]
(Assignee)

Updated

7 years ago
Attachment #448002 - Flags: review?(neil)

Updated

7 years ago
Attachment #448002 - Flags: review?(neil) → review+
(Assignee)

Updated

7 years ago
Keywords: helpwanted, modern → checkin-needed
(Assignee)

Updated

7 years ago
Keywords: helpwanted, modern
Comment on attachment 448002 [details] [diff] [review]
Changed #autoscroller to .autoscroller in global.css [Checkin: comment 8]

http://hg.mozilla.org/comm-central/rev/07eaa92684b8
Attachment #448002 - Attachment description: Changed #autoscroller to .autoscroller in global.css → Changed #autoscroller to .autoscroller in global.css [Checkin: comment 8]
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2

Updated

7 years ago
Keywords: helpwanted
You need to log in before you can comment on or make changes to this bug.