Closed Bug 482218 Opened 12 years ago Closed 11 years ago

[Port Bug 479899 to SeaMonkey Modern] s/#autoscroller/.autoscroller/g

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a2

People

(Reporter: philip.chee, Assigned: ewong)

References

Details

(Keywords: modern, Whiteboard: [good first bug])

Attachments

(1 file)

> There are a number of places in the toolkit theme where id selectors are
> used for some reason. These should be investigated and moved/removed.

> On all platforms, the #autoscroller should be a class.
Note: a) at least for our purposes, the id is being retained
b) there's no indication that the patch will land on branch.
I don't see where we use #autoscroller ?
<http://mxr.mozilla.org/comm-central/search?string=autoscroller>
Oh I missed /mozilla/toolkit/content/widgets/browser.xml.

So what happens when we have nightly trunk builds but haven't branched comm-central?
So, I misread the code, and even if we ported bug 386949 that would fix autoscrolling only in tabbrowser, not in other windows.

Presumably to support both sorts of builds we'd need both selectors.
(In reply to comment #3)
> So what happens when we have nightly trunk builds but haven't branched
> comm-central?

We have no plans to do that, so far. (Just as a note)
We've branched, so this can be fixed properly now!
Keywords: helpwanted
Whiteboard: [good first bug]
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #448002 - Flags: review?(neil)
Attachment #448002 - Flags: review?(neil) → review+
Keywords: helpwanted, modern
Comment on attachment 448002 [details] [diff] [review]
Changed #autoscroller to .autoscroller in global.css [Checkin: comment 8]

http://hg.mozilla.org/comm-central/rev/07eaa92684b8
Attachment #448002 - Attachment description: Changed #autoscroller to .autoscroller in global.css → Changed #autoscroller to .autoscroller in global.css [Checkin: comment 8]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
Keywords: helpwanted
You need to log in before you can comment on or make changes to this bug.