482232 - Using search field in saved password window changes width of search field

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: screenshot

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3

With a fresh profile the show password window is too narrow. So the whole textbox is cut-off and the magnifying glass is not visible. But when you search for a host the textbox width is changed and it will fit into the window with. Even the brush is visible.

Steps:
1. Create a fresh profile
2. Open the page info window of any web page
3. Go to the security tab and press "view saved passwords"
4. Hit ESC to clear the host name from the search textbox

With step 3 the search textbox fits exactly into the window. But hitting ESC stretches the textbox which let it flow outside of the window bounds and cuts-off the magnifying glass.

Comment 1

[Dão Gottwald [:dao]]

Don't think this is a theme bug.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Same happens with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090305 Shiretoko/3.1b4pre ID:20090305020312

Comment 3

[Matthew N. [:MattN]]

Attachment: Set min-width of 500px on description element

The longest string (from current localizations) that will be shown in the <description> of this window is from es-AR:
   Las contrase\u00F1as para los siguientes sitios est\u00E1n guardadas en su computadora:

This fits snug into 450px so 500px leaves room for growth.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 376143 [details] [diff] [review]
Set min-width of 500px on description element

This isn't future-proof, depends on the system font face and size, and is probably the wrong approach anyway.

I think what you want is make the text wrap when it's too long. I.e. set .textContent rather than .value.

Comment 5

[Matthew N. [:MattN]]

Attachment: wrap long text with textContent of descr.

new patch based on suggestion in comment #4

Comment 6

[Justin Dolske [:Dolske]]

(I've got this in my checkin queue with other things, just waiting for a green tree)

Comment 7

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/dee2ce1fce39

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 376310 [details] [diff] [review]
wrap long text with textContent of descr.

a191=beltzner

Comment 9

[Justin Dolske [:Dolske]]

Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fe0bcc4091fb

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on trunk and 1.9.1 on all platforms with builds like

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090517 Minefield/3.6a1pre ID:20090517031115

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b5pre) Gecko/20090519 Shiretoko/3.5b5pre ID:20090519031312

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.