482269 - release automation tag commits should include 'CLOSED TREE' in them

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

As it turns out, the CLOSED TREE hook only pays attention to the last commit, which in our case, is the tag commits. So we need to have this in the tag commits.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: fix the tag commit message

This is simply a copy of the existing tag message with CLOSED TREE at the end. I tested this locally and it seemed ok:
bitters-2:mozilla-1.9.1 bhearsum$ hg log -l3
changeset:   22857:639011932603
branch:      GECKO191b3_20090309_RELBRANCH
tag:         tip
user:        bhearsum_mozilla.com
date:        Mon Mar 09 16:05:08 2009 -0400
summary:     Added tag FIREFOX_3_1b3_RELEASE for changeset 795b050552d0. CLOSED TREE

changeset:   22856:f610729927f6
branch:      GECKO191b3_20090309_RELBRANCH
user:        bhearsum_mozilla.com
date:        Mon Mar 09 16:05:03 2009 -0400
summary:     Added tag FIREFOX_3_1b3_BUILD1 for changeset 795b050552d0. CLOSED TREE

changeset:   22855:795b050552d0
branch:      GECKO191b3_20090309_RELBRANCH
tag:         FIREFOX_3_1b3_BUILD1
tag:         FIREFOX_3_1b3_RELEASE
parent:      22846:d9ff78dd3b4b
user:        bhearsum_mozilla.com
date:        Mon Mar 09 16:04:57 2009 -0400
summary:     Automated checkin: version bump remove "pre"  from version number for firefox 3.1b3 release on GECKO191b3_20090309_RELBRANCH CLOSED TREE

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 366368 [details] [diff] [review]
fix the tag commit message

A little opaque to read but OK.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 366368 [details] [diff] [review]
fix the tag commit message

changeset:   211:40993cb93a6b

Comment 4

[[e-mail] (:bhearsum)]

master reconfig'ed for this.