Closed Bug 482272 Opened 12 years ago Closed 12 years ago
Updates factory failed cvs checkout because of a branch being set
We hit a problem in 3.1b3 where the Signing poller gave a the Updates factory a branch, which caused the CVS step to try and checkout from a non-existant branch. Either we need to make the CVS step override the branch, or just switch it to a ShellCommand. Hooray 'branch' abusing.
As far as I can tell we can't make the CVS Source class ignore branches that come in from a Change, so let's just begone with it and use ShellCommand like the other checkouts.
Attachment #366342 - Flags: review?(catlee)
Comment on attachment 366342 [details] [diff] [review] use ShellCommand instead of CVS Source class >- self.addStep(CVS, >- cvsroot=cvsroot, >- branch=patcherToolsTag, >- cvsmodule='mozilla/tools/patcher' >+ self.addStep(ShellCommand, >+ command=['cvs', '-d', cvsroot, 'co', '-r', patcherTolosTag, typo on this line >+ '-d', 'build', 'mozilla/tools/patcher'], >+ description=['checkout', 'patcher'], >+ haltOnFailure=True > ) > self.addStep(ShellCommand, > command=['cvs', '-d', cvsroot, 'co', '-r', patcherToolsTag, other than that, looks fine.
Attachment #366342 - Flags: review?(catlee) → review+
Thanks for catching that silly mistake, Chris.
Attachment #366342 - Attachment is obsolete: true
Comment on attachment 366351 [details] [diff] [review] fixed patch changeset: 212:89b742a44c72
Attachment #366351 - Flags: checkedâ€‘in+ checked‑in+
master reconfig'ed for this.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.