482272 - Updates factory failed cvs checkout because of a branch being set

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

We hit a problem in 3.1b3 where the Signing poller gave a the Updates factory a branch, which caused the CVS step to try and checkout from a non-existant branch. Either we need to make the CVS step override the branch, or just switch it to a ShellCommand.

Hooray 'branch' abusing.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: use ShellCommand instead of CVS Source class

As far as I can tell we can't make the CVS Source class ignore branches that come in from a Change, so let's just begone with it and use ShellCommand like the other checkouts.

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 366342 [details] [diff] [review]
use ShellCommand instead of CVS Source class

>-        self.addStep(CVS,
>-         cvsroot=cvsroot,
>-         branch=patcherToolsTag,
>-         cvsmodule='mozilla/tools/patcher'
>+        self.addStep(ShellCommand,
>+         command=['cvs', '-d', cvsroot, 'co', '-r', patcherTolosTag,

typo on this line

>+                  '-d', 'build', 'mozilla/tools/patcher'],
>+         description=['checkout', 'patcher'],
>+         haltOnFailure=True
>         )
>         self.addStep(ShellCommand,
>          command=['cvs', '-d', cvsroot, 'co', '-r', patcherToolsTag,

other than that, looks fine.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: fixed patch

Thanks for catching that silly mistake, Chris.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 366351 [details] [diff] [review]
fixed patch

changeset:   212:89b742a44c72

Comment 5

[[e-mail] (:bhearsum)]

master reconfig'ed for this.