Closed Bug 48231 Opened 24 years ago Closed 23 years ago

Default variable-width fonts incorrectly set for KO Windows

Categories

(Core :: Internationalization, defect, P2)

Product:
Core
Component:
Internationalization
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: eungkyu, Assigned: shanjian)

Details

(Keywords: polish, Whiteboard: [nsbeta3+], need sr)

Attachments

(1 file, 1 obsolete file)

different patch, keep Gulim in the fallback list
909 bytes, patch
shanjian
: review+
waterson
: superreview+
Details | Diff | Splinter Review 
Current, default Korean (encoding) font is

???(gulimche) for Serif,
???(gulimche) for Sans Serif,

???(gulimche) for Monospace.

but, ???(gulimche) is fixed-width font.
there is good font for variable-width font, ??(gulim).

I think this is good default for Serif and Sans Serif.
gulimche: ±¼¸²Ã¼
gulim: ±¼¸²

korean is invisible...
trying with Other web browser.
Reassign to erik.
Assignee: nhotta → erik
Confirming bug on KO WinNT and modifying summary to be more specific.
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: teruko → blee
Summary: Default Korean font is not good. → Default variable-width fonts set incorrectly for KO Windows
cc jshin@pantheon.yale.edu 
Good suggestion. 
Can you open the prefs.js and copy that line and put in a file and attach here?
The font name and other prefs will be stored in  UTF-8 . so you should see those 
character in UTF-8
polish, should be easy to do. 
blee- can you copy and past that two lines in the prefs.js here ?
Keywords: nsbeta3, polish
user_pref("font.name.sans-serif.ko", "굴림");
user_pref("font.name.serif.ko", "굴림");

I changed "Character coding" to "UTF-8" and wrote.

굴림체 <- gulimche
굴림 <- gulim

good luck
Marking nbeta3+ per I18N Bug Triage. Erik to address when he returns from
vacation. Looks like easy fix, "two lines of code".
Priority: P3 → P1
Whiteboard: [nsbeta3+]
fix and check in.
Status: NEW → ASSIGNED
Verified fixed in 08-22-08-M18 bld under KO Win NT4.0
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Marking Verified.
Status: RESOLVED → VERIFIED
Summary: Default variable-width fonts set incorrectly for KO Windows → Default variable-width fonts incorrectly set for KO Windows
"Gulim" is the right fit for sans-serif but is
a bad fit for serif. As such, it should NOT be used for
serif. For serif, "Batang" is much better than "Gulim".
You can think of "Batang" as 'Mincho' (in Japanese)
or 'Ming' and "Gulim" as 'Gothic'. 
I'm going to enclose the patch to address this issue.

Somehow Bugzilla's CC didn't work. I have never received
an email about this. I found this while looking for sth. else.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
erik no longer work here. 
give this easy bug to shanjian
Assignee: erik → shanjian
Status: REOPENED → NEW
Priority: P1 → P2
Target Milestone: --- → mozilla0.9.6
Comment on attachment 52024 [details] [diff] [review]
change serif font for Korean MS-Windows

r=ftang
trust jshin's knowledge about Korean
He is the best person we know.
Attachment #52024 - Flags: review+
accepting.
Status: NEW → ASSIGNED
So now all we need is sr. Chris, can you do it? thanks.
Whiteboard: [nsbeta3+] → [nsbeta3+], need sr
Comment on attachment 52024 [details] [diff] [review]
change serif font for Korean MS-Windows

sr=waterson
Attachment #52024 - Flags: superreview+
what will happen on US system. I think usually the font pack do not have Batang,
right?
should we use the new patch?
Blocks: 104056
jshin or shanjian- can you r= it ?
I'm confused as to whether batang comes with lang.pack or not.
Win2k includes both batang and gulim 'by default' (you don't
have to download anything from the net). As for Win9x/ME, 
lang. pack is necessary as you know.....
No matter what, I think the new patch makes sense. 
r=jshin
Blocks: 104060
No longer blocks: 104056
Comment on attachment 54112 [details] [diff] [review]
different patch, keep Gulim in the fallback list

reviewed by Jungshik Shin
Attachment #54112 - Flags: review+
Attachment #52024 - Attachment is obsolete: true
fix and check in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
Comment on attachment 54112 [details] [diff] [review]
different patch, keep Gulim in the fallback list

posthumous sr=waterson
Attachment #54112 - Flags: superreview+
No longer blocks: 104060
reassigning to ylong.
QA Contact: blee → ylong
I checked it on 02-06 trunk build on Win98-KO, looks like the font setting in
preferences now is following the patch in comment #25.

However, on other non-Korean windows, the "font.name-list" in Preferences is not
followed on that patch, e.g. on my WinXP, all serif, san-serif and monospace are
"Batang" although I have more fonts availible on that system.

Is it a correct behavior? seems like san-serif and monospace should be "Gulim"
and "GulimChe" for non-Korean window.  Can some one else help to verify?  Thanks!
> However, on other non-Korean windows, the "font.name-list" in Preferences is not
> followed on that patch, e.g. on my WinXP, all serif, san-serif and monospace are
> "Batang" although I have more fonts availible on that system.

  I didn't test it with 2002-02-06 trunk, but tried it with m 0.9.8 and
couldn't reproduce what you has observed under Win ME (En) and Win2k(En with
En-US locale).  I'll try a nightly build later. (I don't have Win XP so that
I can test it under WinXP). 

> Is it a correct behavior? seems like san-serif and monospace should be "Gulim"
> and "GulimChe" for non-Korean window.

  You're right. Gulim and Gulimche should be used for sans-serif and monospace
if available.   

BTW, it seems like recent lang. pack for Korean(for WinME/9x) has Batang and
Gulimche instead of Gulim and Gulimche. According to my feeble memory,
it used to be Gulim and Gulimche around 1997 as Frank wrote. 
Anyway, to make Mozilla work in both cases, I think we have to 
add 'Batang' as a fallback for sans-serif.
Therefore, the following line 
   pref("font.name-list.sans-serif.ko", "Gulim"); 

had better be replaced with

   pref("font.name-list.sans-serif.ko", "Gulim, Batang"); 


 
I'm marking this one as verified cause the setting for Korean OS seems fine.

We have another bug 125777 to handle non-native OS fonts handle.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: