482356 - Mac skins contain invalid rules

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The Mac skins (mac3.0/personas.css and mac3.1/personas.css) contain a number of invalid declarations and rules.  In some cases it looks like the problem is that a hash character (#) is being used to comment out declarations; in others it looks like rules were accidentally duplicated or incompletely merged.


Here are the invalid parts of mac3.0/personas.css:

#main-window[persona] .tabbrowser-tab {
#  opacity: 0.6;
}

#main-window[persona] .tabbrowser-tab:not([selected="true"]),
}
#main-window[persona] .tab-text {
  font-weight: normal !important;
}

#main-window[persona] .toolbarbutton-1, #back-forward-dropmarker {
#  opacity: 0.9;
}

#main-window[persona] .toolbarbutton-1, #back-forward-dropmarker {
#main-window[persona] .toolbarbutton-1, #back-forward-dropmarker {
  list-style-image: url("chrome://personas/skin/Toolbar.png") !important;
}
  list-style-image: url("chrome://personas/skin/Toolbar.png") !important;
}


Here are the invalid parts of mac3.1/personas.css:

#main-window[persona] toolbar {
  -moz-appearance: none;
  background-color: transparent;
#  background-image: none !important;
}

#main-window[persona] .tabbrowser-strip {
  -moz-appearance: none;
#  background-image: url(chrome://personas/skin/tabbrowser-tabs-bkgnd.png) !important;
  background-color: transparent; 
  background-image: none !important;
}

#main-window[persona] .tabbrowser-tab {
#  opacity: 0.6;
#   color: black !important;
}

#main-window[persona] .tabbrowser-tab[selected="true"],
#main-window[persona] .tabbrowser-tab:hover {
#   background-color: none;
#  opacity: 0.6;
}

#main-window[persona] .tab-text,
#main-window[persona] .tab-text-shadow {
#   font-weight: normal !important;
}

#main-window[persona] .tabbrowser-tab:not([selected="true"]) {
  background-image: url(chrome://personas/skin/tabbrowser-tabs-bkgnd.png) !important;
 #   background-image: url(chrome://browser/skin/tabbrowser/tab-bkgnd.png);
 #  background-image: none !important;
}


The original mac/personas.css file from which those two version-specific files are derived doesn't contain any of these errors, so it looks like they were introduced when the files were split up in changeset 4e210a42d48a <http://hg.mozilla.org/labs/personas/rev/4e210a42d48a>.

Chris: I can fix these, but it'd be good to know your intent with these changes to make sure I don't undo anything accidentally.  Note that the declarations commented out with hash marks aren't being applied, since invalid rules are ignored by the CSS parser, so if the intent was to prevent the rules from being applied, then the hash marks have achieved that goal, although we should still convert them to valid CSS /* comment blocks */ to avoid spamming the Error Console and other unintended consequences.

Comment 1

[Chris Beard]

ack, sorry about that.  the intent was to comment out the declarations.  they can also be safely removed.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Ok, I have a fix in my tree that I'll push for this soon.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset 9aa488ffba95.