482450 - Fix workaround string for the "Open in a New Window" tab context menu item

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Vlado Valastiak [:wladow]]

Attachment: fix the menuitem, v1

As no one has responded on my bug 225680 comment 144 so far, I'm filing a new bug for fixing the temporary workaround, where "Open in a New Window" tab context menu item is using the string taken from Places and has no accesskey. I think we should fix this in 1.9.1 as well, as this is one of the new features in Fx3.5, which we shouldn't introduce with a temporary string and an accessibility issue.

There's bug 455722 already filed for adding "Duplicate tab" or a similar item, currently with uiwanted keyword set. It seems we won't take it in consideration for 1.9.1 and will use the "Open in a New Window" instead, so this bug should not be a dup of bug 455722.

Comment 1

[Axel Hecht [:Pike]]

For the record, I don't really see us taking this patch any more than a working patch in bug 455722 for 3.5.

No idea how to mark up that we should make a call either or.

Comment 2

[Mike Connor [:mconnor]]

Axel, that bug is about duplicating the tab, not detaching the tab.  I think this is quite possibly worthwhile, especially since I think "open in a new window" is a little different from what really happes here.

We should do this before string freeze, IMO, and double check that we want the current string.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 366543 [details] [diff] [review]
fix the menuitem, v1

r=me, thanks!

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Workarounds suck, should definitely fix.

Comment 5

[Vlado Valastiak [:wladow]]

Comment on attachment 366543 [details] [diff] [review]
fix the menuitem, v1

(In reply to comment #2)
> We should do this before string freeze, IMO, and double check that we want the
> current string.
Mike, what do you think? Shall we take the "Open in a New Window" string, or should it be changed to let's say "Move to a New Window" or even something else?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

--> P1, as this bug will require the wider feedback of a beta release or is of sufficient complexity that we should be looking at it sooner, not later.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d9d6c835c2df

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a9f9ff86fedc

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090421 Minefield/3.6a1pre ID:20090421041537

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b4pre) Gecko/20090420 Shiretoko/3.5b4pre ID:20090420044915