Text on provided identity information seems contradicting

VERIFIED FIXED in Firefox 3.6a1

Status

()

Firefox
Page Info Window
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: atopal, Assigned: beltzner)

Tracking

({late-l10n, verified1.9.1})

3.5 Branch
Firefox 3.6a1
late-l10n, verified1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

9 years ago
Created attachment 366573 [details]
screenshot to make the bug report clear

If you click on more information in the site ID dialog, on a website which provides a plain certificate, the page info dialog says that the "Web site does not supply identity information. But two lines below it says: "The web site provides a certificate to verify its identity."

Even I was confused by this.
Hrm, I believe that there's another bug about making deeper changes here, but we should really change that string so that it's not referring to "identity" information but instead "verified identity" or better yet "ownership and operation" information.

It only shows the EV OU/dba field, right?
Assignee: nobody → beltzner
--> 3.1, as we're not going to take a string change on the 3.0.x branch.
Version: 3.0 Branch → 3.1 Branch
Created attachment 366685 [details] [diff] [review]
fixing things by removing things

My first pass was to switch the "Owner:" column to say that the website didn't provide owner information, but we're using "Identity" to mean "verified identity of ownership" throughout the UI so that felt like a half-measure.

The easiest fix is to remove the bit which declares that the certificate is "identity information". Because of that, poking johnath for a ui-review.

I can easily work up the other fix, too.
Attachment #366685 - Flags: ui-review?(johnath)
Attachment #366685 - Flags: review?
Attachment #366685 - Flags: review? → review?(gavin.sharp)
(In reply to comment #3)
> The easiest fix is to remove the bit which declares that the certificate is
> "identity information". Because of that, poking johnath for a ui-review.

by "bit" I mean "string" -- now the "View Certificate" button appears if there's a certificate, doesn't if there isn't. The string saying "This website provides a certificate to verify its identity" has been removed.
Created attachment 366710 [details]
certificate present, yet no string

Just so you don't have to apply the patch yourself.
Created attachment 366722 [details] [diff] [review]
removing things, s/identity/ownership

Gavin felt that having

Owner: This site does not provide any identity information

still felt awkward. He argued that we've been using "identity" to refer to the whole kit and kaboodle: domain name, and verified identity information. Ownership is an important part of identity, but a component of it.

This patch
 - does everything the old patch does
 - changes the string to say "This site does not provide any ownership information"

We are probably overthinking things, but I present them both for your review and approval! My feeling is that either works fine, it's really a matter of how we want to talk about these metaphors across the product, which requires some input from Johnath.
Attachment #366722 - Flags: ui-review?(johnath)
Attachment #366722 - Flags: review?(gavin.sharp)
Created attachment 366725 [details]
screenshot with second patch (security tab)
Created attachment 366726 [details]
screenshot with second patch (general tab)
Keywords: late-l10n
Comment on attachment 366722 [details] [diff] [review]
removing things, s/identity/ownership

I like it. Works in both places it's used (General tab and under "Web Site Identity" on the Security tab), I think.
Attachment #366722 - Flags: review?(gavin.sharp) → review+
Comment on attachment 366685 [details] [diff] [review]
fixing things by removing things

This is OK too, at least insofar as it won't cause the destruction of Firefox and all who love it, but I don't think it's an ideal fix.
Attachment #366685 - Flags: review?(gavin.sharp) → review+
Attachment #366722 - Flags: ui-review?(johnath) → ui-review+
Comment on attachment 366722 [details] [diff] [review]
removing things, s/identity/ownership

Discussed with beltzner and gavin - I think it makes sense to tie the right side text to the left-side heading ("Owner")
Attachment #366685 - Flags: ui-review?(johnath)
Comment on attachment 366685 [details] [diff] [review]
fixing things by removing things

The other one is more betterer, clearing the ui-r flag here.
Keywords: checkin-needed

Updated

9 years ago
Attachment #366685 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/964586e5dbad
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1

Updated

9 years ago
Attachment #366722 - Flags: approval1.9.1?

Updated

9 years ago
Attachment #366710 - Attachment is obsolete: true
Comment on attachment 366722 [details] [diff] [review]
removing things, s/identity/ownership

a191=beltzner
Attachment #366722 - Flags: approval1.9.1? → approval1.9.1+
verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090507 Minefield/3.6a1pre ID:20090507032833

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090507 Shiretoko/3.5b5pre ID:20090507034334
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.