Closed Bug 482517 Opened 15 years ago Closed 15 years ago

[bn-BD] Search engine setup for Firefox 3.1 for Bengali.

Categories

(Mozilla Localizations :: bn-BD / Bengali, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Unassigned)

References

Details

(Keywords: fixed1.9.1, productization)

Attachments

(3 files, 2 obsolete files)

We want to ship Firefox 3.5 a good list of search engines for Bengali. 

We're going to work towards this in three phases. First, the localization team and Stas (Stas Malolepszy) will look at the market for the language and come up with a good set of search providers. Jamil, we'll need your input on this, the guidelines for making recommendations are on http://wiki.mozilla.org/Firefox_web_services_guidelines. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:
Google, Yahoo, Amazon, Answers, CC, eBay, Wikipedia

After we decided on a particular search engine, Stas will contact the owner and ask for permission, and for specifics like proper search flags. undefined, we'll likely need your help to at least get the contact information.

Once we have a specification on what the searchengines for Bengali should look like, the localization team and Stas will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Stas. After a successful review, the localization team will land them.

Please don't commit any modifications in l10n/bn-BD/browser/searchplugins to the cvs repository without a patch reviewed by Stas, Axel or someone else appointed by Stas or SethB. The data here is sensitive to users and our search partners, thus the extra care here.
Component: Other → bn-BD / Bengali
QA Contact: bengali.bn-bd
My comments:

+ Google - For Bangladesh, it will be, google.com.bd
+ Yahoo - 2nd popular search engine.
- Amazon - not popular
+ Answers - Ok
+ CC - Ok
- eBay - not popular
+ Wikipedia - For Bengali, it will be, bn.wikipedia.org
OK, so here is what we have so far:

Generic search:
+ Google.com.bd
+ Yahoo

e-commerce search:

Specific interest search:
+  Answers
+  Creative Commons
+  Wikipedia

Typically we like to have 2 in each category.  Do you have any recommendations for the e-commerce section?  Please feel free to make a suggestion and if possible, provide some usage statistics if any are publicly available.  I realize that this is often not an option, but if you can find it, then great!
We can list following sites for e-commerce search:

http://www.cellbazaar.com/
http://www.clickbd.com/

CellBazaar is a popular one. They got some international award for the idea. Both from Mobile and Web - people can buy/sell items.

Sorry, I don't have any statistics.
Hi Jamil, thanks for good suggestions. Some statistics can be found here: http://www.alexa.com/site/ds/top_sites?cc=BD&ts_mode=country&lang=none

It seems that both callbazaar and clickbd are quite high on the list. If you wish, I'll be happy to contact them for permissions to ship their search plugins.
Sure, please go ahead.

Btw, it is "cellbazaar", not "callbazaar". :)
(In reply to comment #5)
> Btw, it is "cellbazaar", not "callbazaar". :)

Right, sorry, just a typo, I was still thinking about "cell-".

E-mails sent to webteam@clickbd.com and info@cellbazaar.com.
I got replies from clickbd.com and cellbazaar.com. If only all providers were this responsive... ;)

Clickbd:

"Please consider this email as our official acceptation for this
opportunity. Here is the information you have requested -

   URL: *http://www.clickbd.com/search/search.result.php*
   Parameter: *key_words*
   To identify originating source, can you please add *source=mozila*

Example:
http://www.clickbd.com/search/search.result.php?key_words=****&source=mozila
(where **** represent the keyword user searching)"

Cellbazaar:

"Thank you for your mail and it's very exciting. our technical team
will get back to you with the required URL & parameters soon."

Jamil, would you like to give creating the search plug-in for Clickbd.com a try? You can base on the wikipedia.xml plugin, for example. (You can find it in en-US sources).
Attached file Search plug-in for Clickbd.com (obsolete) —
Search plug-in for Clickbd.com. As I could not find any icon of their site/logo, I have removed the <Image> tag from the xml file.
Comment on attachment 370726 [details]
Search plug-in for Clickbd.com

I'm r-'ing this, because ClickBD asked us to use source=mozilla as the second parameter. 

Other than that the file looks good. I would suggest using http://www.clickbd.com/search/search.item.php in <SearchForm/>. What do you think?

Also, for the next time, would you mind attaching a patch (output of |hg diff|) instead of the whole file? It make things easier to review :) Thanks!
Attachment #370726 - Flags: review-
Please check now.
Attachment #370726 - Attachment is obsolete: true
Comment on attachment 372678 [details] [diff] [review]
Search plug-in patch for Clickbd.com

r=me with a nit: please remember to add "clickbd" in searchplugins/list.txt. Otherwise, the plugin won't work.
Attachment #372678 - Flags: review+
Here's a patch that adds google, clickbd, answers, cc and bn.wikipedia. I left yahoo out for now (should we use yahoo.com?), as well as cellbazaar (still waiting for confimration of the search parameters). We will add them later.

I'm going to land this patch today to make sure we have a minimal set of search engines ready for beta4 (the deadline's today)
Attachment #372678 - Attachment is obsolete: true
Attachment #372858 - Flags: review+
Comment on attachment 372858 [details] [diff] [review]
[checked in] patch (adds google, clickbd, answers, cc and bn.wikipedia)

I landed the patch on 1.9.1: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/bn-BD/rev/f68027d0f096

Let's continue to work in this bug on Yahoo and Cellbazaar.
Attachment #372858 - Attachment description: patch (adds google, clickbd, answers, cc and bn.wikipedia) → [checked in] patch (adds google, clickbd, answers, cc and bn.wikipedia)
I emailed Cellbazaar again to ask for the URL to use in the search plugin.

Jamil, what about Yahoo? Should we use yahoo.com?
Staś, CellBazaar sent a mail with a XML file - which needs to be fixed. I have already replied them to fix the parameter.

Yes, we should use yahoo.com too.
Attachment #378139 - Flags: review? → review?(stas)
Comment on attachment 378139 [details] [diff] [review]
Search plug-in for both CellBazaar.com and Yahoo.com

Hi Jamil. Thanks so much for attaching the patch. Please address the following slight formatting nit. Also, just to clarify: you're OK using the en-US yahoo.com website and not any local version, right?

>+<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
>+	<ShortName>সà§à¦²à¦¬à¦¾à¦à¦¾à¦°</ShortName>  
>+	<Url type="text/html" method="GET" template="http://www.cellbazaar.com/external-search/" >  
>+	<Param name="query" value="{searchTerms}"/>
>+	<Param name="client" value="firefox"/>
>+	</Url>
>+	<SearchForm>http://www.cellbazaar.com/external-search/</SearchForm>

Please use zero spaces of indentation for all lines except for the <Param/> lines, which should be indented with 2 spaces. Like so:

<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
<Url type="text/html" method="GET" template="http://www.cellbazaar.com/external-search/" >  
  <Param name="query" value="{searchTerms}"/>
  <Param name="client" value="firefox"/>
</Url>
<SearchForm>http://www.cellbazaar.com/external-search/</SearchForm>

r=me with this fixed. Please land this patch on both branches using a descriptive check-in comment, mentioning the bug number and my review (e.g. "Bug 482517: Search engine setup for Firefox 3.1 for Bengali.").

Please use fixed1.9.1 and verified1.9.1 keywords in this bug to track landing and verification on the 1.9.1 branch.

Thanks, Jamil. Good work.
Attachment #378139 - Flags: review?(stas) → review+
I have fixed the formatting issues, and landed the patch on l10n-mozilla-1.9.1 with descriptive comment. Btw I am not sure about your saying "on both branches". Please help. :)

Yes, I am OK using the en-US yahoo.com website, as there is no local version yet.
Oops! I mentioned "Firefox 3.5" in the check-in comments, is it ok?
(In reply to comment #19)
> Oops! I mentioned "Firefox 3.5" in the check-in comments, is it ok?

Yes, it is. I'm sorry for copying&pasting "Firefox 3.1" from the bug's summary -- it's obviously outdated. Thanks for catching that :) 

For future reference, the landing was: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/bn-BD/rev/288616dc551d

(In reply to comment #18)
> I have fixed the formatting issues, and landed the patch on l10n-mozilla-1.9.1
> with descriptive comment. Btw I am not sure about your saying "on both
> branches". Please help. :)

Sure :) What I meant by this is landing on l10n-mozilla-1.9.1 ("branch") and on l10n-central ("trunk"). But if you wish , the landing on trunk can be done at a later date. For now, 1.91 is our area of focus, so thanks for the landing there.

> Yes, I am OK using the en-US yahoo.com website, as there is no local version
> yet.

OK. Thank you for the clarification.
Keywords: fixed1.9.1
Stas, I want to make minor change in the Bengali wikipedia search plug-in. Patch attached.
Comment on attachment 381342 [details] [diff] [review]
Updated search plug-in for Bengali Wikipedia.

Hi Jamil,

Thanks for the patch. We shouldn't take it, however, so that's an r-. Here's why:

If you go to bn.wikipedia.org and view the source, you'll see this line:

<link rel="search" type="application/opensearchdescription+xml" href="/w/opensearch_desc.php" title="উইকিপিডিয়া (bn)" />

The important thing here is the "title" attribute. If Firefox detects that it already has a plugin whose shortname is the same as the "title" attribute, it assumes it's the same plugin, and doesn't show the notification about a new plugin being available on this site.

So, as you can see, the change from the patch which was:

>-<ShortName>উইকিপিডিয়া (bn)</ShortName>
>+<ShortName>উইকিপিডিয়া</ShortName>

would break this behavior.
Attachment #381342 - Flags: review?(stas) → review-
Sorry, I was not aware of it. Thanks for the information. :)
Sure thing :)
FIXED on 1.9.1 and 1.9.2. Resolving.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: