482537 - Safeguard against exceptions in event-chained tests

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 1

This came up while I was working on bug 473732. If an exception occurs in testActions things, I've seen the test sort of "restart"... which raising concerns. Attaching proposed defense patch.

Comment 1

[Marco Zehe (:MarcoZ)]

Comment on attachment 366605 [details]
patch 1

Could you fix the typo in nsIAccessible_actions.js where the "," is where the ";" should be?

Comment 2

[Marco Zehe (:MarcoZ)]

Running with this patch and the test_nsIAccessible_combobox.xul file enabled, I get a semi-endless loop. The first run goes up to the point where the comboboxes file should be running, then starts over. In this second run, I get the following errors:

28 INFO TEST-PASS | chrome://mochikit/content/a11y/accessible/test_actions.xul | click hasn't been fired for buttonmenu
29 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_actions.xul | Can't get accessible for buttonmenu_item
30 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_actions.xul | Error thrown during test: acc is null - got 0, expected 1

The test run also runs up to test_nsIAccessible_comboboxes.xul.

A third test run passes with all tests also up to test_nsIAccessible_comboboxes.xul.

The fourth test run runs up to this point, then hangs indefinitely:

35 INFO Running chrome://mochikit/content/a11y/accessible/test_actions_aria.html...
36 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_actions_aria.html | Error thrown during test: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMNSDocument.hasFocus]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://mochikit/content/tests/SimpleTest/TestRunner.js :: anonymous :: line 75"  data: no] - got 0, expected 1
38 INFO Running chrome://mochikit/content/a11y/accessible/test_actions_inputs.html...

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 2

Might as well, since we are here.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #2)
> Running with this patch and the test_nsIAccessible_combobox.xul file enabled, I
> get a semi-endless loop.

The whole accessible test suite passes for me with these patches (on Mac).

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 366647 [details] [diff] [review]
patch 2

r=me. Thanks!

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

On second thought, it might be better to move the try catch block into nsIAccessible_actions.js. I'll do that soonish.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 3

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 367095 [details] [diff] [review]
patch 3

Yes, that's the way to go, thanks!

Comment 9

[alexander :surkov (:asurkov)]

Comment on attachment 367095 [details] [diff] [review]
patch 3

fine with me

Comment 10

[Marco Zehe (:MarcoZ)]

Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/b0aeb469c2d4