482563 - Tweak our exposure of object attributes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

I'm not convinced we are doing this quite right. Patch coming soonish.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

The problem is code readability because we have this notion of a bit mask for exposing via object attribute, but in our code, we special case some of them, so by the time we get to the sort of catch-all logic, some of them are already exposed. And that is probably clear as mud. In summary, I think we need to change the flag to more of a 'this attribute is exposed as an object attribute outside of the catch all'.

Hmmm.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 1

Okay, you know when you go back to some code you wrote and you don't understand it? Well I feel it is a pretty good indicator the code is not clear. This bug and patch is just about making it more clear, now, and down the road.

There is no behavioral change here, just renaming and re-commenting.

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 366643 [details] [diff] [review]
patch 1

r=me.

Comment 4

[Marco Zehe (:MarcoZ)]

Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/37141efd1788

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 366643 [details] [diff] [review]
patch 1

Goes hand in hand with bug 475006, which introduced this code logic.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 366643 [details] [diff] [review]
patch 1

a191=beltzner

Comment 7

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8ccff04a839a

Comment 8

[Marco Zehe (:MarcoZ)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)