Closed Bug 482563 Opened 12 years ago Closed 12 years ago

Tweak our exposure of object attributes

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1b4

People

(Reporter: davidb, Assigned: davidb)

Details

(Keywords: access, verified1.9.1)

Attachments

(1 file)

I'm not convinced we are doing this quite right. Patch coming soonish.
The problem is code readability because we have this notion of a bit mask for exposing via object attribute, but in our code, we special case some of them, so by the time we get to the sort of catch-all logic, some of them are already exposed. And that is probably clear as mud. In summary, I think we need to change the flag to more of a 'this attribute is exposed as an object attribute outside of the catch all'.

Hmmm.
Attached patch patch 1Splinter Review
Okay, you know when you go back to some code you wrote and you don't understand it? Well I feel it is a pretty good indicator the code is not clear. This bug and patch is just about making it more clear, now, and down the road.

There is no behavioral change here, just renaming and re-commenting.
Attachment #366643 - Flags: review?(marco.zehe)
Comment on attachment 366643 [details] [diff] [review]
patch 1

r=me.
Attachment #366643 - Flags: review?(marco.zehe) → review+
Flags: wanted1.9.1?
Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/37141efd1788
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: wanted1.9.1?
Comment on attachment 366643 [details] [diff] [review]
patch 1

Goes hand in hand with bug 475006, which introduced this code logic.
Attachment #366643 - Flags: approval1.9.1?
Comment on attachment 366643 [details] [diff] [review]
patch 1

a191=beltzner
Attachment #366643 - Flags: approval1.9.1? → approval1.9.1+
Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8ccff04a839a
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b4
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)
You need to log in before you can comment on or make changes to this bug.