482589 - Find-as-you-type (TAF, FAYT) and normal Find totally fails on Javascript page

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Chris Lawson (gone)]

STR:

1) Visit http://www.sibeliusmusic.com/html/sibeliusmusic/view/reformat.js
2) Attempt to find "write" with the normal Find command, find-as-you-type with autostart on, or FAYT with auto-start off.

ER: Finds "write" twice.

AR: Finds "write" once if used with FAYT, Cmd-G (Find Again) beeps at you. Fails to launch normal Find command at all (beeps).

Broken in latest branch nightly as well as a recent trunk nightly. I suspect this is a regression, but I'm not 100% certain.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

WRT to the 1.8branch, it doesn't work in Firefox, either[1], so it's possibly a Find backend bug there.  If so, good luck with that. ([1] FAYT finds "write" once; Cmd-F won't even open the Firefox Find bar.)

On 1.9.0, Firefox 3.0.7 successfully find all 5 instances of "write", using either Cmd-F, FAYT, or some combination of those plus Cmd-G.

Question: are we preforming menu validation and only allowing Cmd-F/G/Shift-G on 'text' pages?  And said 'text' pages don't include "application/javascript"?  Note the greyed-out menu items and the beeping.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: isTextBasedContent? Yes!

Yeah.

So, according to RFC 4329[1] Section 7, official MIME types for JS and ECMAScript are application/*, with text/* being obsolete but compatibility shims.  HTML5[2] scripting notes the default type for scripting files (when none is specified) is "text/javascript".

This blog entry[3] lists a number of additional possible variants; I suppose we may want to add them, but if they aren't RFCed or HTML-speced and don't seem common, I see no pressing reason to include them.

This patch adds the two RFC-blessed application/* types (and fixes this bug).

[1] http://www.faqs.org/rfcs/rfc4329.html
[2] http://dev.w3.org/html5/spec/Overview.html#scripting-1
[3] http://ajlcom.instantspot.com/blog/2009/02/11/Possible-javascript-file-MIME-types

Comment 3

[Chris Lawson (gone)]

Comment on attachment 366701 [details] [diff] [review]
isTextBasedContent? Yes!

a=me. Ship it!

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 366701 [details] [diff] [review]
isTextBasedContent? Yes!

This does seem to fix Cmd-F/G and FAYT on branch, too, fwiw; perhaps Firefox 2 just had a similar function with similar restrictions there?

Comment 5

[Stuart Morgan]

Comment on attachment 366701 [details] [diff] [review]
isTextBasedContent? Yes!

sr=smorgan

Comment 6

[Chris Lawson (gone)]

Comment on attachment 366701 [details] [diff] [review]
isTextBasedContent? Yes!

Forgot to r+. Oops. Check it in :)

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

Stuart, any objection to taking this fix in 1.6.7?

Comment 8

[Stuart Morgan]

Nope

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the MOZILLA_1_8_BRANCH in advance of 1.6.7.