482601 - write tests for fix to "http-on-examine-response isn't fired when a response comes from the cache" (bug 449198)

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Bug 449198 didn't come with tests. My bad for accepting it. We need tests. Michal, you're on the hook for this.

Comment 1

[Michal Novotny [:michal]]

Attachment: unit test

This test checks what topics are notified in case of
 - normal download
 - partial download
 - requests is satisfied from cache with validation from server
 - requests is satisfied from cache without validation from server

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 367050 [details] [diff] [review]
unit test

Very nice!

Comment 3

[Michal Novotny [:michal]]

(In reply to comment #2)
> (From update of attachment 367050 [details] [diff] [review])
> Very nice!

Thanks :)

Tests don't need superreview, right? Mike, could you please set appropriate approval flags? I'm not sure where should this patch land.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 367050 [details] [diff] [review]
unit test

This needs to land on all branches where bug 449198 landed.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/0baf72f3b278

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 367050 [details] [diff] [review]
unit test

a191=beltzner

Comment 7

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b5bc20f520c2

Comment 8

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b331c6887b9a to fix the resulting orange.