Closed Bug 482614 Opened 16 years ago Closed 16 years ago

mozStorageVariant leaks its internal data due to non-virtual destructor

Categories

(Core :: SQLite and Embedded Database Bindings, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: sdwilsh, Assigned: bent.mozilla)

References

Details

(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b4])

Attachments

(1 file)

just ugh...patch coming. This should block because anyone using the storage async API getting strings or blobs back is going to leak the string buffer or the nsTArray_base for the blob.
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
Priority: P1 → P2
Summary: mozStorageVariant leaks its internal buffer due to non-virtual destructor → mozStorageVariant leaks its internal data due to non-virtual destructor
Target Milestone: --- → mozilla1.9.2a1
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attached patch v1.0Splinter Review
bent made this patch on my machine. r=me
Attachment #366687 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Blocks: 455555
Keywords: fixed1.9.1
Whiteboard: [fixed1.9.1b4]
Product: Toolkit → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: