mozStorageVariant leaks its internal data due to non-virtual destructor

RESOLVED FIXED in mozilla1.9.2a1

Status

()

defect
P2
normal
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sdwilsh, Assigned: bent.mozilla)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9.1 +
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed1.9.1b4])

Attachments

(1 attachment)

Reporter

Description

10 years ago
just ugh...patch coming.

This should block because anyone using the storage async API getting strings or blobs back is going to leak the string buffer or the nsTArray_base for the blob.
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
Reporter

Updated

10 years ago
Priority: P1 → P2
Summary: mozStorageVariant leaks its internal buffer due to non-virtual destructor → mozStorageVariant leaks its internal data due to non-virtual destructor
Target Milestone: --- → mozilla1.9.2a1
Reporter

Updated

10 years ago
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Reporter

Comment 1

10 years ago
Posted patch v1.0Splinter Review
bent made this patch on my machine.  r=me
Attachment #366687 - Flags: review+
Reporter

Comment 2

10 years ago
Thanks ben!

http://hg.mozilla.org/mozilla-central/rev/bb379b26c52e
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Reporter

Comment 3

10 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/01d8fa7182b0

test will be added with bug 481227
Flags: in-testsuite?
Reporter

Updated

10 years ago
Blocks: 455555
Keywords: fixed1.9.1
Whiteboard: [fixed1.9.1b4]
You need to log in before you can comment on or make changes to this bug.