Closed Bug 482649 Opened 11 years ago Closed 11 years ago

Sendchange for hg relauto triggers branch builds

Categories

(Release Engineering :: General, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: bhearsum)

References

Details

Attachments

(1 file)

The --branch=releases/mozilla-1.9.1 part of doing a sendchange to start the automation also triggers all the build/unit/leak builders (it matches their branch). We don't see this in staging because you have to use users/stage-ffxbld/mozilla-1.9.1 there to act on the dummy repo.

IIRC we use the branch for the Mercurial() operation in ReleaseBuildFactory (via MercurialBuildFactory), which is shared with the dep builds. Perhaps isHgPollerTriggered (or an analogue for sendchange) can help here.
Nick, I'm having trouble reproducing this behaviour with a test Buildbot...are you sure there weren't changes being landed around the same time? (I hope not!). I'm going to try and dig up older logs in meantime...
I found the problem, patch incoming.
Assignee: nobody → bhearsum
Priority: -- → P2
Looks like MozScheduler passes fileIsImportant=None and properties={} down to Scheduler, instead of passing the arguments it was passed. This patch fixes that.
Attachment #366904 - Flags: review?(catlee)
Attachment #366904 - Flags: review?(catlee) → review+
Comment on attachment 366904 [details] [diff] [review]
fix MozScheduler to pass along arguments properly

doh, can't believe I wrote that code.
Comment on attachment 366904 [details] [diff] [review]
fix MozScheduler to pass along arguments properly

changeset:   214:efb85303e890
Attachment #366904 - Flags: checked‑in+ checked‑in+
buildbot master has been reconfig'ed for this.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.