482795 - Avoid time encoding and decoding inside of pkix_pl_date object

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Alexei Volkov]

Attachment: Patch v1 - store time as prtime

Most function of the pkix date object have PRTime arguments. Yet, the time inside the object is kept as an encoded SECItem. The patch has appropriate changes to keep time as PRTime.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 366894 [details] [diff] [review]
Patch v1 - store time as prtime

r+ = nelson, after you make two changes:

1) 

>+        PKIX_CHECK(pkix_hash
>+                ((const unsigned char *)&date->nssTime,
>+                sizeof(PRTime),

Please use 
                  sizeof date->nssTime,
instead.

>                 &dateHash,
>                 plContext),
>                 PKIX_HASHFAILED);

2) Change += to = below

>         PRTime time;

>+        time += PR_Now() + PR_SecondsToInterval(secondsOffset);

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Alexei, Don't forget to commit this after making the changes suggested above.

Comment 3

[Alexei Volkov]

landed.